include/effects/SkMorphologyImageFilter.h - Issue 1216433005: style nit cleanups. e.g. remove 'virtual' on override declarations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/effects/SkMorphologyImageFilter.h

Issue 1216433005: style nit cleanups. e.g. remove 'virtual' on override declarations (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Address code review issues Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: include/effects/SkMorphologyImageFilter.h

diff --git a/include/effects/SkMorphologyImageFilter.h b/include/effects/SkMorphologyImageFilter.h

index 7d409e87534ea65d8465286f2e1fa29bb988d575..3a242250cbe7b228edc39e3d5e2e6815e06514d7 100644

--- a/include/effects/SkMorphologyImageFilter.h

+++ b/include/effects/SkMorphologyImageFilter.h

@@ -60,11 +60,11 @@ public:

return SkNEW_ARGS(SkDilateImageFilter, (radiusX, radiusY, input, cropRect));

}

- virtual bool onFilterImage(Proxy*, const SkBitmap& src, const Context&,

- SkBitmap* result, SkIPoint* offset) const override;

+ bool onFilterImage(Proxy*, const SkBitmap& src, const Context&,

+ SkBitmap* result, SkIPoint* offset) const override;

#if SK_SUPPORT_GPU

- virtual bool filterImageGPU(Proxy* proxy, const SkBitmap& src, const Context&,

- SkBitmap* result, SkIPoint* offset) const override;

+ bool filterImageGPU(Proxy* proxy, const SkBitmap& src, const Context&,

+ SkBitmap* result, SkIPoint* offset) const override;

#endif

SK_TO_STRING_OVERRIDE()

@@ -88,11 +88,11 @@ public:

return SkNEW_ARGS(SkErodeImageFilter, (radiusX, radiusY, input, cropRect));

}

- virtual bool onFilterImage(Proxy*, const SkBitmap& src, const Context&,

- SkBitmap* result, SkIPoint* offset) const override;

+ bool onFilterImage(Proxy*, const SkBitmap& src, const Context&,

+ SkBitmap* result, SkIPoint* offset) const override;

#if SK_SUPPORT_GPU

- virtual bool filterImageGPU(Proxy* proxy, const SkBitmap& src, const Context&,

- SkBitmap* result, SkIPoint* offset) const override;

+ bool filterImageGPU(Proxy* proxy, const SkBitmap& src, const Context&,

+ SkBitmap* result, SkIPoint* offset) const override;

#endif

SK_TO_STRING_OVERRIDE()

« no previous file with comments | « include/effects/SkBitmapSource.h ('k') | include/effects/SkXfermodeImageFilter.h » ('j') | no next file with comments »