Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: include/effects/SkXfermodeImageFilter.h

Issue 1216433005: style nit cleanups. e.g. remove 'virtual' on override declarations (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Address code review issues Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « include/effects/SkMorphologyImageFilter.h ('k') | include/gpu/GrContext.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2013 The Android Open Source Project 2 * Copyright 2013 The Android Open Source Project
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #ifndef SkXfermodeImageFilter_DEFINED 8 #ifndef SkXfermodeImageFilter_DEFINED
9 #define SkXfermodeImageFilter_DEFINED 9 #define SkXfermodeImageFilter_DEFINED
10 10
(...skipping 15 matching lines...) Expand all
26 static SkXfermodeImageFilter* Create(SkXfermode* mode, SkImageFilter* backgr ound, 26 static SkXfermodeImageFilter* Create(SkXfermode* mode, SkImageFilter* backgr ound,
27 SkImageFilter* foreground = NULL, 27 SkImageFilter* foreground = NULL,
28 const CropRect* cropRect = NULL) { 28 const CropRect* cropRect = NULL) {
29 SkImageFilter* inputs[2] = { background, foreground }; 29 SkImageFilter* inputs[2] = { background, foreground };
30 return SkNEW_ARGS(SkXfermodeImageFilter, (mode, inputs, cropRect)); 30 return SkNEW_ARGS(SkXfermodeImageFilter, (mode, inputs, cropRect));
31 } 31 }
32 32
33 SK_TO_STRING_OVERRIDE() 33 SK_TO_STRING_OVERRIDE()
34 SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(SkXfermodeImageFilter) 34 SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(SkXfermodeImageFilter)
35 35
36 virtual bool onFilterImage(Proxy* proxy, 36 bool onFilterImage(Proxy* proxy,
37 const SkBitmap& src, 37 const SkBitmap& src,
38 const Context& ctx, 38 const Context& ctx,
39 SkBitmap* dst, 39 SkBitmap* dst,
40 SkIPoint* offset) const override; 40 SkIPoint* offset) const override;
41 #if SK_SUPPORT_GPU 41 #if SK_SUPPORT_GPU
42 bool canFilterImageGPU() const override; 42 bool canFilterImageGPU() const override;
43 virtual bool filterImageGPU(Proxy* proxy, const SkBitmap& src, const Context & ctx, 43 bool filterImageGPU(Proxy* proxy, const SkBitmap& src, const Context& ctx,
44 SkBitmap* result, SkIPoint* offset) const overri de; 44 SkBitmap* result, SkIPoint* offset) const override;
45 #endif 45 #endif
46 46
47 protected: 47 protected:
48 SkXfermodeImageFilter(SkXfermode* mode, SkImageFilter* inputs[2], 48 SkXfermodeImageFilter(SkXfermode* mode, SkImageFilter* inputs[2],
49 const CropRect* cropRect); 49 const CropRect* cropRect);
50 void flatten(SkWriteBuffer&) const override; 50 void flatten(SkWriteBuffer&) const override;
51 51
52 private: 52 private:
53 SkXfermode* fMode; 53 SkXfermode* fMode;
54 typedef SkImageFilter INHERITED; 54 typedef SkImageFilter INHERITED;
55 }; 55 };
56 56
57 #endif 57 #endif
OLDNEW
« no previous file with comments | « include/effects/SkMorphologyImageFilter.h ('k') | include/gpu/GrContext.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698