include/effects/SkXfermodeImageFilter.h - Issue 1216433005: style nit cleanups. e.g. remove 'virtual' on override declarations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/effects/SkXfermodeImageFilter.h

Issue 1216433005: style nit cleanups. e.g. remove 'virtual' on override declarations (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Address code review issues Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: include/effects/SkXfermodeImageFilter.h

diff --git a/include/effects/SkXfermodeImageFilter.h b/include/effects/SkXfermodeImageFilter.h

index 2115ee44ddf8cb80978017e6b11fa75d0f2f0633..30a3a5ccd5da25f3eba6eee2b3d5140e26521795 100644

--- a/include/effects/SkXfermodeImageFilter.h

+++ b/include/effects/SkXfermodeImageFilter.h

@@ -33,15 +33,15 @@ public:

SK_TO_STRING_OVERRIDE()

SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(SkXfermodeImageFilter)

- virtual bool onFilterImage(Proxy* proxy,

- const SkBitmap& src,

- const Context& ctx,

- SkBitmap* dst,

- SkIPoint* offset) const override;

+ bool onFilterImage(Proxy* proxy,

+ const SkBitmap& src,

+ const Context& ctx,

+ SkBitmap* dst,

+ SkIPoint* offset) const override;

#if SK_SUPPORT_GPU

bool canFilterImageGPU() const override;

- virtual bool filterImageGPU(Proxy* proxy, const SkBitmap& src, const Context& ctx,

- SkBitmap* result, SkIPoint* offset) const override;

+ bool filterImageGPU(Proxy* proxy, const SkBitmap& src, const Context& ctx,

+ SkBitmap* result, SkIPoint* offset) const override;

#endif

protected:

« no previous file with comments | « include/effects/SkMorphologyImageFilter.h ('k') | include/gpu/GrContext.h » ('j') | no next file with comments »