Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ui/aura/window.cc

Issue 1213193003: Remove DCHECK_IMPLIES and CHECK_IMPLIES (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/common/discardable_shared_memory_heap.cc ('K') | « gpu/command_buffer/service/texture_definition.cc ('k') | ui/base/resource/data_pack.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/aura/window.cc
diff --git a/ui/aura/window.cc b/ui/aura/window.cc
index 1e293b72343b994b81641e0f7570d74d2105ce0c..68d068d7c05638de459f11aaac746a71d0c82361 100644
--- a/ui/aura/window.cc
+++ b/ui/aura/window.cc
@@ -328,7 +328,7 @@ void Window::Show() {
// It is not allowed that a window is visible but the layers alpha is fully
// transparent since the window would still be considered to be active but
// could not be seen.
- DCHECK_IMPLIES(visible_, layer()->GetTargetOpacity() > 0.0f);
+ DCHECK(!visible_ || (layer()->GetTargetOpacity() > 0.0f));
SetVisible(true);
}
« content/common/discardable_shared_memory_heap.cc ('K') | « gpu/command_buffer/service/texture_definition.cc ('k') | ui/base/resource/data_pack.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698