Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ui/base/resource/data_pack.cc

Issue 1213193003: Remove DCHECK_IMPLIES and CHECK_IMPLIES (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/common/discardable_shared_memory_heap.cc ('K') | « ui/aura/window.cc ('k') | ui/events/blink/blink_event_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/resource/data_pack.cc
diff --git a/ui/base/resource/data_pack.cc b/ui/base/resource/data_pack.cc
index 82d33633693250777da3efdf90f5a488b25d0323..1e2c8920ee1b12629e465a87615104a31fb79a21 100644
--- a/ui/base/resource/data_pack.cc
+++ b/ui/base/resource/data_pack.cc
@@ -240,9 +240,9 @@ void DataPack::CheckForDuplicateResources(
const uint16 resource_id = entry->resource_id;
const float resource_scale = GetScaleForScaleFactor(scale_factor_);
for (const ResourceHandle* handle : packs) {
- DCHECK_IMPLIES(
- GetScaleForScaleFactor(handle->GetScaleFactor()) == resource_scale,
- !handle->HasResource(resource_id));
+ DCHECK((GetScaleForScaleFactor(handle->GetScaleFactor()) !=
+ resource_scale) ||
+ !handle->HasResource(resource_id));
}
}
}
« content/common/discardable_shared_memory_heap.cc ('K') | « ui/aura/window.cc ('k') | ui/events/blink/blink_event_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698