gpu/command_buffer/service/texture_definition.cc - Issue 1213193003: Remove DCHECK_IMPLIES and CHECK_IMPLIES

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/texture_definition.cc

Issue 1213193003: Remove DCHECK_IMPLIES and CHECK_IMPLIES (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gpu/command_buffer/service/texture_definition.cc

diff --git a/gpu/command_buffer/service/texture_definition.cc b/gpu/command_buffer/service/texture_definition.cc

index c19b5d3d47cf03c76182a07143059209c2585d1f..cdef8ad88afb99da3914d94f19245c37feea262f 100644

--- a/gpu/command_buffer/service/texture_definition.cc

+++ b/gpu/command_buffer/service/texture_definition.cc

@@ -361,7 +361,7 @@ TextureDefinition::TextureDefinition(

usage_(texture->usage()),

immutable_(texture->IsImmutable()),

defined_(texture->IsDefined()) {

- DCHECK_IMPLIES(image_buffer_.get(), defined_);

+ DCHECK(!image_buffer_.get() || defined_);

if (!image_buffer_.get() && defined_) {

image_buffer_ = NativeImageBuffer::Create(texture->service_id());

DCHECK(image_buffer_.get());