Chromium Code Reviews| Index: content/common/discardable_shared_memory_heap.cc |
| diff --git a/content/common/discardable_shared_memory_heap.cc b/content/common/discardable_shared_memory_heap.cc |
| index 01adeb850f0ed802f18bb5e85ed37dcfdd7646d3..88cc63d998503315f33ac3a0974c62afac04b40f 100644 |
| --- a/content/common/discardable_shared_memory_heap.cc |
| +++ b/content/common/discardable_shared_memory_heap.cc |
| @@ -149,8 +149,8 @@ DiscardableSharedMemoryHeap::Split(Span* span, size_t blocks) { |
| scoped_ptr<Span> leftover(new Span( |
| span->shared_memory_, span->start_ + blocks, span->length_ - blocks)); |
| - DCHECK_IMPLIES(leftover->length_ > 1, |
| - spans_.find(leftover->start_) == spans_.end()); |
| + DCHECK((leftover->length_ <= 1) || |
|
danakj
2015/06/29 19:30:58
can you make this == 1? I think that blocks<span->
|
| + (spans_.find(leftover->start_) == spans_.end())); |
| RegisterSpan(leftover.get()); |
| spans_[span->start_ + blocks - 1] = span; |
| span->length_ = blocks; |
| @@ -253,7 +253,7 @@ DiscardableSharedMemoryHeap::Carve(Span* span, size_t blocks) { |
| if (extra) { |
| scoped_ptr<Span> leftover( |
| new Span(serving->shared_memory_, serving->start_ + blocks, extra)); |
| - DCHECK_IMPLIES(extra > 1, spans_.find(leftover->start_) == spans_.end()); |
| + DCHECK((extra <= 1) || (spans_.find(leftover->start_) == spans_.end())); |
|
danakj
2015/06/29 19:30:58
can you make this == 1
|
| RegisterSpan(leftover.get()); |
| // No need to coalesce as the previous span of |leftover| was just split |