Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 1213003004: Fix virtual/override/final usage in Source/platform/. (Closed)

Created:
5 years, 5 months ago by tkent
Modified:
5 years, 5 months ago
Reviewers:
keishi, haraken
CC:
blink-reviews, shans, vikasa, urvang, dshwang, rwlbuis, Yoav Weiss, krit, drott+blinkwatch_chromium.org, skal, Justin Novosad, danakj, Rik, Eric Willigers, rjwright, Mads Ager (chromium), jbroman, Raymond Toy, tommyw+watchlist_chromium.org, pdr+graphicswatchlist_chromium.org, darktears, jzern, gavinp+prerender_chromium.org, blink-reviews-animation_chromium.org, blink-layers+watch_chromium.org, f(malita), oilpan-reviews, Stephen Chennney, kouhei+heap_chromium.org, scheduler-bugs_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix virtual/override/final usage in Source/platform/. - We should specify just one of them to a function. This was done by the following command. % sed -i "" -E "s/virtual (.*) final/\1 final/g; s/virtual (.*) override/\1 override/g; s/override final/final/g" <files> - Non-base virtual destructors should have |override| keywords. This CL has no behavior changes. BUG=417463 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198474

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+893 lines, -895 lines) Patch
M Source/platform/JSONValues.h View 6 chunks +19 lines, -19 lines 0 comments Download
M Source/platform/PODArena.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/PODIntervalTree.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/RefCountedSupplement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/Task.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/TestingPlatformSupport.h View 2 chunks +9 lines, -9 lines 0 comments Download
M Source/platform/Timer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/TimerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/TracedValue.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/UserGestureIndicator.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/animation/TimingFunction.h View 3 chunks +15 lines, -15 lines 0 comments Download
M Source/platform/audio/AudioDSPKernelProcessor.h View 1 chunk +8 lines, -8 lines 0 comments Download
M Source/platform/audio/AudioDelayDSPKernel.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/platform/audio/AudioDestination.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/audio/EqualPowerPanner.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/platform/audio/HRTFPanner.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/platform/audio/MultiChannelResampler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/audio/SincResampler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/audio/StereoPanner.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/platform/blob/BlobRegistry.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/credentialmanager/PlatformFederatedCredential.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/credentialmanager/PlatformPasswordCredential.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/exported/WebMediaStreamSource.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/exported/WebPrerender.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/exported/WebScrollbarImpl.h View 1 chunk +20 lines, -20 lines 0 comments Download
M Source/platform/exported/WebScrollbarThemeClientImpl.h View 1 chunk +38 lines, -38 lines 0 comments Download
M Source/platform/exported/WebScrollbarThemeGeometryNative.h View 1 chunk +17 lines, -17 lines 0 comments Download
M Source/platform/exported/WebURLRequest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/exported/WebURLResponse.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/FontCacheTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/platform/fonts/GlyphPageTreeNode.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/fonts/GlyphPageTreeNodeTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/SegmentedFontData.h View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/platform/fonts/SimpleFontData.h View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/platform/geometry/FloatPolygon.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/BitmapImage.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/graphics/BitmapImageTest.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/graphics/BitmapPattern.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/platform/graphics/BitmapPatternBase.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/Canvas2DImageBufferSurface.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/Canvas2DLayerBridge.h View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/platform/graphics/Canvas2DLayerManager.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/graphics/ContentLayerDelegate.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/platform/graphics/CrossfadeGeneratedImage.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/platform/graphics/DecodingImageGenerator.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/platform/graphics/DeferredImageDecoderTest.cpp View 2 chunks +9 lines, -9 lines 0 comments Download
M Source/platform/graphics/GeneratedImage.h View 2 chunks +9 lines, -9 lines 0 comments Download
M Source/platform/graphics/GradientGeneratedImage.h View 1 chunk +1 line, -3 lines 0 comments Download
M Source/platform/graphics/GraphicsLayer.h View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/platform/graphics/GraphicsLayerDebugInfo.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/ImageDecodingStore.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/ImageFrameGenerator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/ImageFrameGeneratorTest.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/platform/graphics/LoggingCanvas.h View 1 chunk +26 lines, -26 lines 0 comments Download
M Source/platform/graphics/PicturePattern.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/RecordingImageBufferSurface.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp View 4 chunks +9 lines, -9 lines 0 comments Download
M Source/platform/graphics/StaticBitmapImage.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/StaticBitmapPattern.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/platform/graphics/UnacceleratedImageBufferSurface.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/platform/graphics/filters/DistantLightSource.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/graphics/filters/FEBlend.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/filters/FEColorMatrix.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/graphics/filters/FEComponentTransfer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/platform/graphics/filters/FEComposite.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/platform/graphics/filters/FEConvolveMatrix.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/platform/graphics/filters/FEDiffuseLighting.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/filters/FEDisplacementMap.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/platform/graphics/filters/FEDropShadow.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/platform/graphics/filters/FEFlood.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/platform/graphics/filters/FEGaussianBlur.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/platform/graphics/filters/FELighting.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/graphics/filters/FEMerge.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/filters/FEMorphology.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/platform/graphics/filters/FEOffset.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/platform/graphics/filters/FESpecularLighting.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/filters/FETile.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/platform/graphics/filters/FETurbulence.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/filters/FilterOperation.h View 6 chunks +17 lines, -17 lines 0 comments Download
M Source/platform/graphics/filters/PointLightSource.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/platform/graphics/filters/ReferenceFilter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/filters/SourceAlpha.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/platform/graphics/filters/SourceGraphic.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/platform/graphics/filters/SpotLightSource.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/platform/graphics/gpu/DrawingBuffer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/graphics/gpu/DrawingBufferTest.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/platform/graphics/paint/CachedDisplayItem.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/paint/ClipDisplayItem.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/platform/graphics/paint/ClipPathDisplayItem.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/platform/graphics/paint/CompositingDisplayItem.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/platform/graphics/paint/DisplayItem.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/graphics/paint/DisplayItemListTest.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/graphics/paint/DrawingDisplayItem.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/graphics/paint/FilterDisplayItem.h View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/platform/graphics/paint/FixedPositionContainerDisplayItem.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/platform/graphics/paint/FixedPositionDisplayItem.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/platform/graphics/paint/FloatClipDisplayItem.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/platform/graphics/paint/ScrollDisplayItem.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/platform/graphics/paint/SubtreeDisplayItem.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/graphics/paint/Transform3DDisplayItem.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/platform/graphics/paint/TransformDisplayItem.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/platform/graphics/test/MockImageDecoder.h View 2 chunks +11 lines, -11 lines 0 comments Download
M Source/platform/heap/GarbageCollected.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/heap/Heap.h View 8 chunks +27 lines, -27 lines 0 comments Download
M Source/platform/heap/HeapTest.cpp View 10 chunks +31 lines, -31 lines 0 comments Download
M Source/platform/heap/MarkingVisitor.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/platform/heap/glue/MessageLoopInterruptor.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/image-decoders/bmp/BMPImageDecoder.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/platform/image-decoders/gif/GIFImageDecoder.h View 2 chunks +12 lines, -12 lines 0 comments Download
M Source/platform/image-decoders/ico/ICOImageDecoder.h View 2 chunks +10 lines, -10 lines 0 comments Download
M Source/platform/image-decoders/jpeg/JPEGImageDecoder.h View 2 chunks +11 lines, -11 lines 0 comments Download
M Source/platform/image-decoders/png/PNGImageDecoder.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/platform/image-decoders/webp/WEBPImageDecoder.h View 2 chunks +12 lines, -12 lines 0 comments Download
M Source/platform/mac/ScrollAnimatorMac.h View 2 chunks +27 lines, -27 lines 0 comments Download
M Source/platform/mac/ThemeMac.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/mediastream/MediaStreamCenter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/mediastream/MediaStreamComponent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/mediastream/MediaStreamWebAudioSource.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/plugins/PluginListBuilder.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/platform/scheduler/CancellableTaskFactory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/scroll/ScrollAnimatorNone.h View 1 chunk +10 lines, -10 lines 0 comments Download
M Source/platform/scroll/Scrollbar.h View 4 chunks +44 lines, -44 lines 0 comments Download
M Source/platform/scroll/ScrollbarThemeAura.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/platform/scroll/ScrollbarThemeMacCommon.h View 1 chunk +9 lines, -9 lines 0 comments Download
M Source/platform/scroll/ScrollbarThemeMacNonOverlayAPI.h View 1 chunk +11 lines, -11 lines 0 comments Download
M Source/platform/scroll/ScrollbarThemeMacOverlayAPI.h View 1 chunk +15 lines, -15 lines 0 comments Download
M Source/platform/scroll/ScrollbarThemeMock.h View 1 chunk +10 lines, -10 lines 0 comments Download
M Source/platform/scroll/ScrollbarThemeNonMacCommon.h View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/platform/scroll/ScrollbarThemeOverlay.h View 1 chunk +14 lines, -14 lines 0 comments Download
M Source/platform/scroll/ScrollbarThemeOverlayMock.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/testing/ArenaTestHelpers.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/text/DateTimeFormatTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/text/LineEnding.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/platform/text/LocaleICU.h View 1 chunk +17 lines, -17 lines 0 comments Download
M Source/platform/text/LocaleMac.h View 1 chunk +16 lines, -16 lines 0 comments Download
M Source/platform/text/LocaleWin.h View 2 chunks +16 lines, -16 lines 0 comments Download
M Source/platform/text/PlatformLocale.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/transforms/IdentityTransformOperation.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/platform/transforms/InterpolatedTransformOperation.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/platform/transforms/Matrix3DTransformOperation.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/transforms/MatrixTransformOperation.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/transforms/PerspectiveTransformOperation.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/transforms/RotateTransformOperation.h View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/transforms/ScaleTransformOperation.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/platform/transforms/SkewTransformOperation.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/transforms/TranslateTransformOperation.h View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/platform/weborigin/KURL.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
tkent
Keishi, please review this.
5 years, 5 months ago (2015-07-08 03:46:12 UTC) #2
haraken
LGTM
5 years, 5 months ago (2015-07-08 04:08:20 UTC) #3
keishi
lgtm
5 years, 5 months ago (2015-07-08 04:09:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213003004/1
5 years, 5 months ago (2015-07-08 04:25:02 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 06:52:55 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198474

Powered by Google App Engine
This is Rietveld 408576698