Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Side by Side Diff: Source/platform/heap/MarkingVisitor.h

Issue 1213003004: Fix virtual/override/final usage in Source/platform/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/platform/heap/HeapTest.cpp ('k') | Source/platform/heap/glue/MessageLoopInterruptor.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MarkingVisitor_h 5 #ifndef MarkingVisitor_h
6 #define MarkingVisitor_h 6 #define MarkingVisitor_h
7 7
8 #include "platform/heap/MarkingVisitorImpl.h" 8 #include "platform/heap/MarkingVisitorImpl.h"
9 9
10 namespace blink { 10 namespace blink {
11 11
12 template <Visitor::MarkingMode Mode> 12 template <Visitor::MarkingMode Mode>
13 class MarkingVisitor final : public Visitor, public MarkingVisitorImpl<MarkingVi sitor<Mode>> { 13 class MarkingVisitor final : public Visitor, public MarkingVisitorImpl<MarkingVi sitor<Mode>> {
14 public: 14 public:
15 using Impl = MarkingVisitorImpl<MarkingVisitor<Mode>>; 15 using Impl = MarkingVisitorImpl<MarkingVisitor<Mode>>;
16 friend class MarkingVisitorImpl<MarkingVisitor<Mode>>; 16 friend class MarkingVisitorImpl<MarkingVisitor<Mode>>;
17 17
18 MarkingVisitor() 18 MarkingVisitor()
19 : Visitor(Mode) 19 : Visitor(Mode)
20 { 20 {
21 } 21 }
22 22
23 virtual void markHeader(HeapObjectHeader* header, TraceCallback callback) ov erride 23 void markHeader(HeapObjectHeader* header, TraceCallback callback) override
24 { 24 {
25 Impl::markHeader(header, header->payload(), callback); 25 Impl::markHeader(header, header->payload(), callback);
26 } 26 }
27 27
28 virtual void mark(const void* objectPointer, TraceCallback callback) overrid e 28 void mark(const void* objectPointer, TraceCallback callback) override
29 { 29 {
30 Impl::mark(objectPointer, callback); 30 Impl::mark(objectPointer, callback);
31 } 31 }
32 32
33 virtual void registerDelayedMarkNoTracing(const void* object) override 33 void registerDelayedMarkNoTracing(const void* object) override
34 { 34 {
35 Impl::registerDelayedMarkNoTracing(object); 35 Impl::registerDelayedMarkNoTracing(object);
36 } 36 }
37 37
38 virtual void registerWeakMembers(const void* closure, const void* objectPoin ter, WeakCallback callback) override 38 void registerWeakMembers(const void* closure, const void* objectPointer, Wea kCallback callback) override
39 { 39 {
40 Impl::registerWeakMembers(closure, objectPointer, callback); 40 Impl::registerWeakMembers(closure, objectPointer, callback);
41 } 41 }
42 42
43 virtual void registerWeakTable(const void* closure, EphemeronCallback iterat ionCallback, EphemeronCallback iterationDoneCallback) 43 virtual void registerWeakTable(const void* closure, EphemeronCallback iterat ionCallback, EphemeronCallback iterationDoneCallback)
44 { 44 {
45 Impl::registerWeakTable(closure, iterationCallback, iterationDoneCallbac k); 45 Impl::registerWeakTable(closure, iterationCallback, iterationDoneCallbac k);
46 } 46 }
47 47
48 #if ENABLE(ASSERT) 48 #if ENABLE(ASSERT)
49 virtual bool weakTableRegistered(const void* closure) 49 virtual bool weakTableRegistered(const void* closure)
50 { 50 {
51 return Impl::weakTableRegistered(closure); 51 return Impl::weakTableRegistered(closure);
52 } 52 }
53 #endif 53 #endif
54 54
55 virtual bool ensureMarked(const void* objectPointer) override 55 bool ensureMarked(const void* objectPointer) override
56 { 56 {
57 return Impl::ensureMarked(objectPointer); 57 return Impl::ensureMarked(objectPointer);
58 } 58 }
59 59
60 protected: 60 protected:
61 virtual void registerWeakCellWithCallback(void** cell, WeakCallback callback ) override 61 void registerWeakCellWithCallback(void** cell, WeakCallback callback) overri de
62 { 62 {
63 Impl::registerWeakCellWithCallback(cell, callback); 63 Impl::registerWeakCellWithCallback(cell, callback);
64 } 64 }
65 65
66 inline bool shouldMarkObject(const void* objectPointer) 66 inline bool shouldMarkObject(const void* objectPointer)
67 { 67 {
68 if (Mode != ThreadLocalMarking) 68 if (Mode != ThreadLocalMarking)
69 return true; 69 return true;
70 70
71 BasePage* page = pageFromObject(objectPointer); 71 BasePage* page = pageFromObject(objectPointer);
72 ASSERT(!page->orphaned()); 72 ASSERT(!page->orphaned());
73 // When doing a thread local GC, the marker checks if 73 // When doing a thread local GC, the marker checks if
74 // the object resides in another thread's heap. If it 74 // the object resides in another thread's heap. If it
75 // does, the object should not be marked & traced. 75 // does, the object should not be marked & traced.
76 return page->terminating(); 76 return page->terminating();
77 } 77 }
78 }; 78 };
79 79
80 } // namespace blink 80 } // namespace blink
81 81
82 #endif 82 #endif
OLDNEW
« no previous file with comments | « Source/platform/heap/HeapTest.cpp ('k') | Source/platform/heap/glue/MessageLoopInterruptor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698