Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Side by Side Diff: Source/platform/graphics/paint/SubtreeDisplayItem.h

Issue 1213003004: Fix virtual/override/final usage in Source/platform/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef SubtreeDisplayItem_h 5 #ifndef SubtreeDisplayItem_h
6 #define SubtreeDisplayItem_h 6 #define SubtreeDisplayItem_h
7 7
8 #include "platform/geometry/FloatRect.h" 8 #include "platform/geometry/FloatRect.h"
9 #include "platform/graphics/paint/DisplayItem.h" 9 #include "platform/graphics/paint/DisplayItem.h"
10 #include "wtf/Assertions.h" 10 #include "wtf/Assertions.h"
11 11
12 namespace blink { 12 namespace blink {
13 13
14 class PLATFORM_EXPORT SubtreeCachedDisplayItem : public DisplayItem { 14 class PLATFORM_EXPORT SubtreeCachedDisplayItem : public DisplayItem {
15 public: 15 public:
16 SubtreeCachedDisplayItem(const DisplayItemClientWrapper& client, Type type) 16 SubtreeCachedDisplayItem(const DisplayItemClientWrapper& client, Type type)
17 : DisplayItem(client, type) 17 : DisplayItem(client, type)
18 { 18 {
19 ASSERT(isSubtreeCachedType(type)); 19 ASSERT(isSubtreeCachedType(type));
20 } 20 }
21 21
22 virtual void replay(GraphicsContext&) override final { ASSERT_NOT_REACHED(); } 22 void replay(GraphicsContext&) final { ASSERT_NOT_REACHED(); }
23 virtual void appendToWebDisplayItemList(WebDisplayItemList*) const override final { ASSERT_NOT_REACHED(); } 23 void appendToWebDisplayItemList(WebDisplayItemList*) const final { ASSERT_NO T_REACHED(); }
24 }; 24 };
25 25
26 class PLATFORM_EXPORT BeginSubtreeDisplayItem : public PairedBeginDisplayItem { 26 class PLATFORM_EXPORT BeginSubtreeDisplayItem : public PairedBeginDisplayItem {
27 public: 27 public:
28 BeginSubtreeDisplayItem(const DisplayItemClientWrapper& client, Type type) 28 BeginSubtreeDisplayItem(const DisplayItemClientWrapper& client, Type type)
29 : PairedBeginDisplayItem(client, type) 29 : PairedBeginDisplayItem(client, type)
30 { 30 {
31 ASSERT(isBeginSubtreeType(type)); 31 ASSERT(isBeginSubtreeType(type));
32 } 32 }
33 }; 33 };
34 34
35 class PLATFORM_EXPORT EndSubtreeDisplayItem : public PairedEndDisplayItem { 35 class PLATFORM_EXPORT EndSubtreeDisplayItem : public PairedEndDisplayItem {
36 public: 36 public:
37 EndSubtreeDisplayItem(const DisplayItemClientWrapper& client, Type type) 37 EndSubtreeDisplayItem(const DisplayItemClientWrapper& client, Type type)
38 : PairedEndDisplayItem(client, type) 38 : PairedEndDisplayItem(client, type)
39 { 39 {
40 ASSERT(isEndSubtreeType(type)); 40 ASSERT(isEndSubtreeType(type));
41 } 41 }
42 42
43 #if ENABLE(ASSERT) 43 #if ENABLE(ASSERT)
44 virtual bool isEndAndPairedWith(DisplayItem::Type otherType) const override final { return DisplayItem::isBeginSubtreeType(otherType); } 44 bool isEndAndPairedWith(DisplayItem::Type otherType) const final { return Di splayItem::isBeginSubtreeType(otherType); }
45 #endif 45 #endif
46 }; 46 };
47 47
48 } // namespace blink 48 } // namespace blink
49 49
50 #endif // SubtreeDisplayItem_h 50 #endif // SubtreeDisplayItem_h
OLDNEW
« no previous file with comments | « Source/platform/graphics/paint/ScrollDisplayItem.h ('k') | Source/platform/graphics/paint/Transform3DDisplayItem.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698