Fix accounting and logging of HttpStream request and job bindings.

Fix accounting and logging of HttpStream request and job bindings.

This fixes some codepaths where a request would be bound to a job (or bound to
no job if a SPDY session was established) without properly orphaning or canceling
all other jobs.

Also, log the binding in NetLog at the point where the jobs are bound, rather than
in Complete. NetLog currently loses track of which Job was bound if the bound Job
failed.

This doesn't fix the URL_REQUEST not logging the result of a failed Job.

BUG=504443
Committed: https://crrev.com/3e005d44ef8d8b67b7be8d0c1a73b60941680aef
Cr-Commit-Position: refs/heads/master@{#336688}

[davidben, 2015-06-25 23:04:17]

davidben@chromium.org changed reviewers:
+ mmenke@chromium.org

[davidben, 2015-06-25 23:04:18]

Some possibility try jobs will explode. I did it on top of
https://codereview.chromium.org/1212153002/ and haven't checked if the patch
applies in the other order too.

[mmenke, 2015-06-25 23:20:20]

LGTM

https://codereview.chromium.org/1212493003/diff/1/net/http/http_stream_factor...
File net/http/http_stream_factory_impl_request.cc (right):

https://codereview.chromium.org/1212493003/diff/1/net/http/http_stream_factor...
net/http/http_stream_factory_impl_request.cc:127: OrphanJobsExcept(job);
This is kind of silly.  Can we rename this?  "BindJobAndOrphanOthers" or just
"BindJob"?

[davidben, 2015-06-26 19:16:29]

davidben@chromium.org changed reviewers:
+ rch@chromium.org

[davidben, 2015-06-26 19:16:29]

davidben@chromium.org changed required reviewers:
+ rch@chromium.org

[davidben, 2015-06-26 19:16:30]

https://codereview.chromium.org/1212493003/diff/1/net/http/http_stream_factor...
File net/http/http_stream_factory_impl_request.cc (right):

https://codereview.chromium.org/1212493003/diff/1/net/http/http_stream_factor...
net/http/http_stream_factory_impl_request.cc:127: OrphanJobsExcept(job);
On 2015/06/25 23:20:20, mmenke (Off June 26 to July 5) wrote:
> This is kind of silly.  Can we rename this?  "BindJobAndOrphanOthers" or just
> "BindJob"?

Done. Though in doing that and trying to figure out the responsibilities of that
method, it seems there's a few other variants of the bug here where we don't
disconnect from jobs and the SpdySessionRequest map when something resolves.
I've gone ahead and resolved them in this CL since the NetLog thing is pretty
tangential in comparison.

+rch to make sure I haven't done anything crazy with the orphaned/canceled job
tracking.

[Ryan Hamilton, 2015-06-28 16:12:47]

lgtm

[davidben, 2015-06-29 22:57:28]

The CQ bit was checked by davidben@chromium.org

[davidben, 2015-06-29 22:57:29]

The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/1212493003/#ps40001
(title: "comment typo")

[commit-bot: I haz the power, 2015-06-29 22:58:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1212493003/40001

[commit-bot: I haz the power, 2015-06-30 00:01:53]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-06-30 00:03:01]

Patchset 3 (id:??) landed as
https://crrev.com/3e005d44ef8d8b67b7be8d0c1a73b60941680aef
Cr-Commit-Position: refs/heads/master@{#336688}