Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Unified Diff: net/http/http_stream_factory_impl_request.h

Issue 1212493003: Fix accounting and logging of HttpStream request and job bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@stream-job-logging
Patch Set: comment typo Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_stream_factory_impl_job.cc ('k') | net/http/http_stream_factory_impl_request.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_stream_factory_impl_request.h
diff --git a/net/http/http_stream_factory_impl_request.h b/net/http/http_stream_factory_impl_request.h
index 48c85b20df7ab945e50d39007b5a3c6cbfc35a97..e65dac88e45600f7e1bf1d529079276284f296e8 100644
--- a/net/http/http_stream_factory_impl_request.h
+++ b/net/http/http_stream_factory_impl_request.h
@@ -48,11 +48,9 @@ class HttpStreamFactoryImpl::Request : public HttpStreamRequest {
void AttachJob(HttpStreamFactoryImpl::Job* job);
// Marks completion of the request. Must be called before OnStreamReady().
- // |job_net_log| is the BoundNetLog of the Job that fulfilled this request.
void Complete(bool was_npn_negotiated,
NextProto protocol_negotiated,
- bool using_spdy,
- const BoundNetLog& job_net_log);
+ bool using_spdy);
// If this Request has a |spdy_session_key_|, remove this session from the
// SpdySessionRequestMap.
@@ -118,13 +116,15 @@ class HttpStreamFactoryImpl::Request : public HttpStreamRequest {
const ConnectionAttempts& connection_attempts() const override;
private:
- // Used to orphan all jobs in |jobs_| other than |job| which becomes "bound"
- // to the request.
- void OrphanJobsExcept(Job* job);
+ // Used to bind |job| to the request and orphan all other jobs in |jobs_|.
+ void BindJob(Job* job);
// Used to orphan all jobs in |jobs_|.
void OrphanJobs();
+ // Used to cancel all jobs in |jobs_|.
+ void CancelJobs();
+
// Called when a Job succeeds.
void OnJobSucceeded(Job* job);
« no previous file with comments | « net/http/http_stream_factory_impl_job.cc ('k') | net/http/http_stream_factory_impl_request.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698