Track all jobs associated with an HttpStreamRequest.

Track all jobs associated with an HttpStreamRequest.

If an HttpStreamJob is orphaned or fails, NetLog loses any association between
it and the HttpStreamRequest.

BUG=504443
Committed: https://crrev.com/f59ef141c9c00f1b60071f91636836ec506ebd95
Cr-Commit-Position: refs/heads/master@{#336669}

[davidben, 2015-06-25 23:03:22]

davidben@chromium.org changed reviewers:
+ mmenke@chromium.org

[mmenke, 2015-06-25 23:23:27]

LGTM

https://codereview.chromium.org/1212153002/diff/1/net/http/http_stream_factor...
File net/http/http_stream_factory_impl_job.cc (right):

https://codereview.chromium.org/1212153002/diff/1/net/http/http_stream_factor...
net/http/http_stream_factory_impl_job.cc:673: NetLog::TYPE_HTTP_STREAM_JOB,
Should update the docs for this method's parameters.  Looks like the docs don't
currently mention any of them.  :(

[mmenke, 2015-06-25 23:25:20]

https://codereview.chromium.org/1212153002/diff/1/net/log/net_log_event_type_...
File net/log/net_log_event_type_list.h (right):

https://codereview.chromium.org/1212153002/diff/1/net/log/net_log_event_type_...
net/log/net_log_event_type_list.h:1003: // Job.
The description could be clearer...Maybe "...because the Job's Request was bound
to another Job that succeeded.  The Job will continue to run to completion."

[davidben, 2015-06-26 16:35:43]

https://codereview.chromium.org/1212153002/diff/1/net/http/http_stream_factor...
File net/http/http_stream_factory_impl_job.cc (right):

https://codereview.chromium.org/1212153002/diff/1/net/http/http_stream_factor...
net/http/http_stream_factory_impl_job.cc:673: NetLog::TYPE_HTTP_STREAM_JOB,
On 2015/06/25 23:23:27, mmenke (Off June 26 to July 5) wrote:
> Should update the docs for this method's parameters.  Looks like the docs
don't
> currently mention any of them.  :(

Done.

https://codereview.chromium.org/1212153002/diff/1/net/log/net_log_event_type_...
File net/log/net_log_event_type_list.h (right):

https://codereview.chromium.org/1212153002/diff/1/net/log/net_log_event_type_...
net/log/net_log_event_type_list.h:1003: // Job.
On 2015/06/25 23:25:20, mmenke (Off June 26 to July 5) wrote:
> The description could be clearer...Maybe "...because the Job's Request was
bound
> to another Job that succeeded.  The Job will continue to run to completion."

Well, it's not necessarily that the job succeeded. It might have given a special
error like needing client certs. Mentioned running to completion though.

[Huh, related to what we were talking about elsewhere, here's an example where
we depend on lifetimes of lower-level objects being correct.]

[davidben, 2015-06-29 20:15:03]

The CQ bit was checked by davidben@chromium.org

[davidben, 2015-06-29 20:15:03]

The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/1212153002/#ps20001
(title: "tweak comments")

[commit-bot: I haz the power, 2015-06-29 20:16:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1212153002/20001

[commit-bot: I haz the power, 2015-06-29 22:53:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-06-29 22:53:58]

Patchset 2 (id:??) landed as
https://crrev.com/f59ef141c9c00f1b60071f91636836ec506ebd95
Cr-Commit-Position: refs/heads/master@{#336669}