net/http/http_stream_factory_impl_job.cc - Issue 1212493003: Fix accounting and logging of HttpStream request and job bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_stream_factory_impl_job.cc

Issue 1212493003: Fix accounting and logging of HttpStream request and job bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@stream-job-logging

Patch Set: comment typo Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_stream_factory_impl_job.cc

diff --git a/net/http/http_stream_factory_impl_job.cc b/net/http/http_stream_factory_impl_job.cc

index f0d3a4f75591622553402605ea1776f029ffa85c..cca64c1b9519921bf7bc5a251d7276736cd78467 100644

--- a/net/http/http_stream_factory_impl_job.cc

+++ b/net/http/http_stream_factory_impl_job.cc

@@ -326,10 +326,8 @@ void HttpStreamFactoryImpl::Job::OnStreamReadyCallback() {

if (IsOrphaned()) {

stream_factory_->OnOrphanedJobComplete(this);

} else {

- request_->Complete(was_npn_negotiated(),

- protocol_negotiated(),

- using_spdy(),

- net_log_);

+ request_->Complete(was_npn_negotiated(), protocol_negotiated(),

+ using_spdy());

request_->OnStreamReady(this, server_ssl_config_, proxy_info_,

stream_.release());

}

@@ -346,10 +344,7 @@ void HttpStreamFactoryImpl::Job::OnWebSocketHandshakeStreamReadyCallback() {

MaybeCopyConnectionAttemptsFromSocketOrHandle();

- request_->Complete(was_npn_negotiated(),

- protocol_negotiated(),

- using_spdy(),

- net_log_);

+ request_->Complete(was_npn_negotiated(), protocol_negotiated(), using_spdy());

request_->OnWebSocketHandshakeStreamReady(this,

server_ssl_config_,

proxy_info_,

« no previous file with comments | « net/http/http_stream_factory_impl.cc ('k') | net/http/http_stream_factory_impl_request.h » ('j') | no next file with comments »