Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1212023004: Convert all usages of mojo::ErrorHandler in //device/serial to callbacks. (Closed)

Created:
5 years, 5 months ago by tanay.c
Modified:
5 years, 5 months ago
CC:
eroman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert all usages of mojo::ErrorHandler in //device/serial to callbacks. BUG=504666 Committed: https://crrev.com/ba624cb6517d35196d8f9011c1a7f0ebde8b230e Cr-Commit-Position: refs/heads/master@{#337587}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -30 lines) Patch
M device/serial/data_receiver.h View 2 chunks +3 lines, -4 lines 0 comments Download
M device/serial/data_receiver.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M device/serial/data_sender.h View 3 chunks +4 lines, -4 lines 0 comments Download
M device/serial/data_sender.cc View 1 chunk +2 lines, -1 line 0 comments Download
M device/serial/data_sink_receiver.h View 2 chunks +2 lines, -3 lines 0 comments Download
M device/serial/data_sink_receiver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M device/serial/data_source_sender.h View 1 2 chunks +3 lines, -4 lines 0 comments Download
M device/serial/data_source_sender.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M device/serial/serial_connection_unittest.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M device/serial/serial_service_unittest.cc View 4 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
tanay.c
Please review.
5 years, 5 months ago (2015-07-06 09:42:45 UTC) #2
eroman
Removing myself as reviewer -- will defer review to an OWNER of //device
5 years, 5 months ago (2015-07-06 22:50:27 UTC) #5
Reilly Grant (use Gerrit)
lgtm with one nit https://codereview.chromium.org/1212023004/diff/1/device/serial/data_source_sender.h File device/serial/data_source_sender.h (left): https://codereview.chromium.org/1212023004/diff/1/device/serial/data_source_sender.h#oldcode52 device/serial/data_source_sender.h:52: // Invoked in the event ...
5 years, 5 months ago (2015-07-06 23:03:14 UTC) #6
tanay.c
Modified as per review comments. https://codereview.chromium.org/1212023004/diff/1/device/serial/data_source_sender.h File device/serial/data_source_sender.h (left): https://codereview.chromium.org/1212023004/diff/1/device/serial/data_source_sender.h#oldcode52 device/serial/data_source_sender.h:52: // Invoked in the ...
5 years, 5 months ago (2015-07-07 05:29:12 UTC) #7
Reilly Grant (use Gerrit)
lgtm
5 years, 5 months ago (2015-07-07 05:34:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212023004/20001
5 years, 5 months ago (2015-07-07 10:38:47 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-07 11:28:03 UTC) #11
commit-bot: I haz the power
5 years, 5 months ago (2015-07-07 11:28:59 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/ba624cb6517d35196d8f9011c1a7f0ebde8b230e
Cr-Commit-Position: refs/heads/master@{#337587}

Powered by Google App Engine
This is Rietveld 408576698