Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Unified Diff: device/serial/data_receiver.h

Issue 1212023004: Convert all usages of mojo::ErrorHandler in //device/serial to callbacks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | device/serial/data_receiver.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/serial/data_receiver.h
diff --git a/device/serial/data_receiver.h b/device/serial/data_receiver.h
index 95be6402085adc8cc7d9808713278dcc295642d8..774d3958753bde9966d7725d5757aea0fa812ec9 100644
--- a/device/serial/data_receiver.h
+++ b/device/serial/data_receiver.h
@@ -19,8 +19,7 @@ namespace device {
// A DataReceiver receives data from a DataSource.
class DataReceiver : public base::RefCounted<DataReceiver>,
- public serial::DataSourceClient,
- public mojo::ErrorHandler {
+ public serial::DataSourceClient {
public:
typedef base::Callback<void(scoped_ptr<ReadOnlyBuffer>)> ReceiveDataCallback;
typedef base::Callback<void(int32_t error)> ReceiveErrorCallback;
@@ -53,8 +52,8 @@ class DataReceiver : public base::RefCounted<DataReceiver>,
// Invoked by the DataSource transmit data.
void OnData(mojo::Array<uint8_t> data) override;
- // mojo::ErrorHandler override. Calls ShutDown().
- void OnConnectionError() override;
+ // mojo error handler
+ void OnConnectionError();
// Invoked by the PendingReceive to report that the user is done with the
// receive buffer, having read |bytes_read| bytes from it.
« no previous file with comments | « no previous file | device/serial/data_receiver.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698