Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: device/serial/data_source_sender.h

Issue 1212023004: Convert all usages of mojo::ErrorHandler in //device/serial to callbacks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/serial/data_sink_receiver.cc ('k') | device/serial/data_source_sender.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/serial/data_source_sender.h
diff --git a/device/serial/data_source_sender.h b/device/serial/data_source_sender.h
index a8c2c634712e9a9a35e5f3ee23d95e1ee883da4d..2de7ce64d6acae2df2395405d80e015a2bf12307 100644
--- a/device/serial/data_source_sender.h
+++ b/device/serial/data_source_sender.h
@@ -19,8 +19,7 @@ namespace device {
// A DataSourceSender is an interface between a source of data and a
// DataSourceClient.
class DataSourceSender : public base::RefCounted<DataSourceSender>,
- public serial::DataSource,
- public mojo::ErrorHandler {
+ public serial::DataSource {
public:
typedef base::Callback<void(scoped_ptr<WritableBuffer>)> ReadyCallback;
typedef base::Callback<void()> ErrorCallback;
@@ -49,8 +48,8 @@ class DataSourceSender : public base::RefCounted<DataSourceSender>,
void Init(uint32_t buffer_size) override;
void Resume() override;
void ReportBytesReceived(uint32_t bytes_sent) override;
- // Invoked in the event of a connection error. Calls DispatchFatalError().
- void OnConnectionError() override;
+ // mojo error handler. Calls DispatchFatalError().
+ void OnConnectionError();
// Gets more data to send to the DataSourceClient.
void GetMoreData();
« no previous file with comments | « device/serial/data_sink_receiver.cc ('k') | device/serial/data_source_sender.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698