Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3058)

Unified Diff: device/serial/data_sender.h

Issue 1212023004: Convert all usages of mojo::ErrorHandler in //device/serial to callbacks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/serial/data_receiver.cc ('k') | device/serial/data_sender.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/serial/data_sender.h
diff --git a/device/serial/data_sender.h b/device/serial/data_sender.h
index 93b06449362aefaffdf665c2eda42eba7fbdc43e..5c46c35ebdaa4a07897ab1a3720416ff7a505ecb 100644
--- a/device/serial/data_sender.h
+++ b/device/serial/data_sender.h
@@ -17,7 +17,7 @@
namespace device {
// A DataSender sends data to a DataSink.
-class DataSender : public mojo::ErrorHandler {
+class DataSender {
public:
typedef base::Callback<void(uint32_t bytes_sent)> DataSentCallback;
typedef base::Callback<void(uint32_t bytes_sent, int32_t error)>
@@ -30,7 +30,7 @@ class DataSender : public mojo::ErrorHandler {
uint32_t buffer_size,
int32_t fatal_error_value);
- ~DataSender() override;
+ ~DataSender();
// Starts an asynchronous send of |data|. If the send completes successfully,
// |callback| will be called. Otherwise, |error_callback| will be called with
@@ -55,8 +55,8 @@ class DataSender : public mojo::ErrorHandler {
// Invoked when a PendingSend fails with |error|.
void SendFailed(int32_t error);
- // mojo::ErrorHandler override.
- void OnConnectionError() override;
+ // mojo error handler
+ void OnConnectionError();
// Dispatches a cancel callback if one is pending.
void RunCancelCallback();
« no previous file with comments | « device/serial/data_receiver.cc ('k') | device/serial/data_sender.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698