Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 120983002: Update some uses of UTF conversions in chrome/browser to use the base:: namespace. (Closed)

Created:
6 years, 12 months ago by Avi (use Gerrit)
Modified:
6 years, 12 months ago
CC:
chromium-reviews, vandebo (ex-Chrome), skanuj+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, yoshiki+watch_chromium.org, dcheng, ajwong+watch_chromium.org, tim+watch_chromium.org, extensions-reviews_chromium.org, melevin+watch_chromium.org, dominich, marja+watch_chromium.org, groby+spellwatch_chromium.org, chromium-apps-reviews_chromium.org, rpetterson, creis+watch_chromium.org, samarth+watch_chromium.org, haitaol+watch_chromium.org, rouslan+spellwatch_chromium.org, jfweitz+watch_chromium.org, Jered, maniscalco+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, Lei Zhang, tfarina, donnd+watch_chromium.org, tommycli, David Black, Greg Billock, kmadhusu+watch_chromium.org, rsimha+watch_chromium.org
Visibility:
Public.

Description

Update some uses of UTF conversions in chrome/browser to use the base:: namespace. BUG=330556 TEST=no change TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242465

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+519 lines, -451 lines) Patch
M chrome/browser/renderer_host/pepper/pepper_flash_clipboard_message_filter.cc View 6 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/renderer_host/plugin_info_message_filter_unittest.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/rlz/rlz.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/rlz/rlz_unittest.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page.cc View 7 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/search/search.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/search_engines/search_provider_install_data_unittest.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/search_engines/template_url.cc View 11 chunks +22 lines, -20 lines 0 comments Download
M chrome/browser/search_engines/template_url_fetcher_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/search_engines/template_url_parser.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/search_engines/template_url_parser_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/search_engines/template_url_prepopulate_data.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/search_engines/template_url_service.cc View 12 chunks +23 lines, -22 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_sync_unittest.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_util_unittest.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/search_engines/template_url_unittest.cc View 4 chunks +10 lines, -7 lines 0 comments Download
M chrome/browser/sessions/better_session_restore_browsertest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/sessions/restore_on_startup_policy_handler_unittest.cc View 4 chunks +10 lines, -7 lines 0 comments Download
M chrome/browser/sessions/session_types_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sessions/tab_restore_browsertest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/shell_integration_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/shell_integration_linux_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/shell_integration_win.cc View 5 chunks +11 lines, -8 lines 0 comments Download
M chrome/browser/shell_integration_win_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/signin/about_signin_internals.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/signin/signin_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/signin/signin_names_io_thread.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/signin/signin_names_io_thread_unittest.cc View 7 chunks +14 lines, -12 lines 0 comments Download
M chrome/browser/signin/signin_ui_util.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/speech/speech_recognition_bubble_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/speech/tts_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/spellchecker/feedback.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/spellchecker/feedback_sender_unittest.cc View 9 chunks +23 lines, -23 lines 0 comments Download
M chrome/browser/spellchecker/feedback_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/spellchecker/misspelling.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/spellchecker/misspelling_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_action_unittest.cc View 1 chunk +12 lines, -8 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_host_metrics_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/spellchecker/spellcheck_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/spellchecker/spellcheck_message_filter_mac_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/spellchecker/spellcheck_message_filter_mac_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_message_filter_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_platform_mac_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/spellchecker/spelling_service_client_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/spellchecker/word_trimmer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/spellchecker/word_trimmer_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ssl/ssl_blocking_page.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ssl/ssl_error_info.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ssl/ssl_tab_helper.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/status_icons/status_icon_menu_model_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/status_icons/status_tray_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/storage_monitor/media_storage_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/storage_monitor/media_transfer_protocol_device_observer_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/storage_monitor/media_transfer_protocol_device_observer_linux_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/storage_monitor/portable_device_watcher_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/storage_monitor/storage_monitor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/storage_monitor/storage_monitor_chromeos.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/storage_monitor/storage_monitor_linux.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/storage_monitor/storage_monitor_linux_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/storage_monitor/storage_monitor_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/storage_monitor/storage_monitor_mac_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/storage_monitor/storage_monitor_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/storage_monitor/storage_monitor_win_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/storage_monitor/test_portable_device_watcher_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/storage_monitor/test_volume_mount_watcher_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/storage_monitor/volume_mount_watcher_win.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/sync/about_sync_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/bookmark_change_processor.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/bookmark_model_associator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/generic_change_processor.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/password_model_associator.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/session_model_associator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/session_sync_test_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/synced_device_tracker.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/synced_session_tracker.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/tab_node_pool.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/typed_url_change_processor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/typed_url_model_associator.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/typed_url_model_associator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_autofill_unittest.cc View 4 chunks +10 lines, -7 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_bookmark_unittest.cc View 16 chunks +32 lines, -31 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_password_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_typed_url_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/sync_ui_util.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/sync/sync_ui_util_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/bookmarks_helper.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/sync/test/integration/multiple_client_typed_urls_sync_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/passwords_helper.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/performance/autofill_sync_perf_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/performance/passwords_sync_perf_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/search_engines_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/two_client_autofill_sync_test.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/sync/test/integration/two_client_passwords_sync_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/two_client_search_engines_sync_test.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/sync/test/integration/two_client_typed_urls_sync_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/test/integration/typed_urls_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/spelling_menu_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/spelling_menu_observer_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/view_source_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/background_resource_provider.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/task_manager/extension_process_resource_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/task_manager/task_manager_notification_browsertest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/task_manager/task_manager_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/task_manager/task_manager_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/worker_resource_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/translate/translate_browsertest.cc View 6 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/ui/android/infobars/auto_login_infobar_delegate_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/android/login_prompt_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_controller_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service_interactive_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/app_search_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/app_search_provider_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/search/history.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/search/mixer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/search/people/people_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/people/people_provider_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/search/people/people_result.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/search/search_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/search/search_webstore_result.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/term_break_iterator_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/search/tokenized_string_char_iterator_unittest.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/app_list/search/tokenized_string_match_unittest.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/app_list/search/tokenized_string_unittest.cc View 2 chunks +17 lines, -17 lines 0 comments Download
M chrome/browser/ui/app_list/search/webstore/webstore_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/webstore/webstore_provider_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/search/webstore/webstore_result.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Avi (use Gerrit)
6 years, 12 months ago (2013-12-24 23:24:30 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 manually as r242465 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698