Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Side by Side Diff: chrome/browser/sessions/restore_on_startup_policy_handler_unittest.cc

Issue 120983002: Update some uses of UTF conversions in chrome/browser to use the base:: namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "base/compiler_specific.h" 7 #include "base/compiler_specific.h"
8 #include "base/memory/scoped_ptr.h" 8 #include "base/memory/scoped_ptr.h"
9 #include "base/prefs/pref_value_map.h" 9 #include "base/prefs/pref_value_map.h"
10 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 }; 46 };
47 47
48 TEST_F(RestoreOnStartupPolicyHandlerTest, CheckPolicySettings_FailsTypeCheck) { 48 TEST_F(RestoreOnStartupPolicyHandlerTest, CheckPolicySettings_FailsTypeCheck) {
49 // Handler expects an int; pass it a bool. 49 // Handler expects an int; pass it a bool.
50 SetPolicyValue(key::kRestoreOnStartup, new base::FundamentalValue(false)); 50 SetPolicyValue(key::kRestoreOnStartup, new base::FundamentalValue(false));
51 // Checking should fail and add an error to the error map. 51 // Checking should fail and add an error to the error map.
52 EXPECT_FALSE(CheckPolicySettings()); 52 EXPECT_FALSE(CheckPolicySettings());
53 EXPECT_EQ(1U, errors().size()); 53 EXPECT_EQ(1U, errors().size());
54 EXPECT_EQ(l10n_util::GetStringFUTF16( 54 EXPECT_EQ(l10n_util::GetStringFUTF16(
55 IDS_POLICY_TYPE_ERROR, 55 IDS_POLICY_TYPE_ERROR,
56 ASCIIToUTF16(ConfigurationPolicyHandler::ValueTypeToString( 56 base::ASCIIToUTF16(
57 base::Value::TYPE_INTEGER))), 57 ConfigurationPolicyHandler::ValueTypeToString(
58 base::Value::TYPE_INTEGER))),
58 errors().begin()->second); 59 errors().begin()->second);
59 } 60 }
60 61
61 TEST_F(RestoreOnStartupPolicyHandlerTest, CheckPolicySettings_Unspecified) { 62 TEST_F(RestoreOnStartupPolicyHandlerTest, CheckPolicySettings_Unspecified) {
62 // Don't specify a value for the policy. 63 // Don't specify a value for the policy.
63 // Checking should succeed with no errors. 64 // Checking should succeed with no errors.
64 EXPECT_TRUE(CheckPolicySettings()); 65 EXPECT_TRUE(CheckPolicySettings());
65 EXPECT_EQ(0U, errors().size()); 66 EXPECT_EQ(0U, errors().size());
66 } 67 }
67 68
68 TEST_F(RestoreOnStartupPolicyHandlerTest, CheckPolicySettings_UnknownValue) { 69 TEST_F(RestoreOnStartupPolicyHandlerTest, CheckPolicySettings_UnknownValue) {
69 // Specify an unknown value for the policy. 70 // Specify an unknown value for the policy.
70 int impossible_value = SessionStartupPref::kPrefValueHomePage + 71 int impossible_value = SessionStartupPref::kPrefValueHomePage +
71 SessionStartupPref::kPrefValueLast + 72 SessionStartupPref::kPrefValueLast +
72 SessionStartupPref::kPrefValueURLs + 73 SessionStartupPref::kPrefValueURLs +
73 SessionStartupPref::kPrefValueNewTab; 74 SessionStartupPref::kPrefValueNewTab;
74 SetPolicyValue(key::kRestoreOnStartup, 75 SetPolicyValue(key::kRestoreOnStartup,
75 new base::FundamentalValue(impossible_value)); 76 new base::FundamentalValue(impossible_value));
76 // Checking should succeed but add an error to the error map. 77 // Checking should succeed but add an error to the error map.
77 EXPECT_TRUE(CheckPolicySettings()); 78 EXPECT_TRUE(CheckPolicySettings());
78 EXPECT_EQ(1U, errors().size()); 79 EXPECT_EQ(1U, errors().size());
79 EXPECT_EQ(l10n_util::GetStringFUTF16( 80 EXPECT_EQ(l10n_util::GetStringFUTF16(
80 IDS_POLICY_OUT_OF_RANGE_ERROR, 81 IDS_POLICY_OUT_OF_RANGE_ERROR,
81 ASCIIToUTF16(base::IntToString(impossible_value))), 82 base::ASCIIToUTF16(base::IntToString(impossible_value))),
82 errors().begin()->second); 83 errors().begin()->second);
83 } 84 }
84 85
85 TEST_F(RestoreOnStartupPolicyHandlerTest, CheckPolicySettings_HomePage) { 86 TEST_F(RestoreOnStartupPolicyHandlerTest, CheckPolicySettings_HomePage) {
86 // Specify the HomePage value. 87 // Specify the HomePage value.
87 SetPolicyValue( 88 SetPolicyValue(
88 key::kRestoreOnStartup, 89 key::kRestoreOnStartup,
89 new base::FundamentalValue(SessionStartupPref::kPrefValueHomePage)); 90 new base::FundamentalValue(SessionStartupPref::kPrefValueHomePage));
90 // Checking should succeed but add an error to the error map. 91 // Checking should succeed but add an error to the error map.
91 EXPECT_TRUE(CheckPolicySettings()); 92 EXPECT_TRUE(CheckPolicySettings());
92 EXPECT_EQ(1U, errors().size()); 93 EXPECT_EQ(1U, errors().size());
93 EXPECT_EQ(l10n_util::GetStringUTF16(IDS_POLICY_VALUE_DEPRECATED), 94 EXPECT_EQ(l10n_util::GetStringUTF16(IDS_POLICY_VALUE_DEPRECATED),
94 errors().begin()->second); 95 errors().begin()->second);
95 } 96 }
96 97
97 TEST_F(RestoreOnStartupPolicyHandlerTest, 98 TEST_F(RestoreOnStartupPolicyHandlerTest,
98 CheckPolicySettings_RestoreLastSession_SessionCookies) { 99 CheckPolicySettings_RestoreLastSession_SessionCookies) {
99 // Specify the Last value and the Session-Only Cookies value. 100 // Specify the Last value and the Session-Only Cookies value.
100 SetPolicyValue( 101 SetPolicyValue(
101 key::kRestoreOnStartup, 102 key::kRestoreOnStartup,
102 new base::FundamentalValue(SessionStartupPref::kPrefValueLast)); 103 new base::FundamentalValue(SessionStartupPref::kPrefValueLast));
103 scoped_ptr<base::ListValue> urls(new base::ListValue); 104 scoped_ptr<base::ListValue> urls(new base::ListValue);
104 urls->AppendString("http://foo.com"); 105 urls->AppendString("http://foo.com");
105 SetPolicyValue(key::kCookiesSessionOnlyForUrls, urls.release()); 106 SetPolicyValue(key::kCookiesSessionOnlyForUrls, urls.release());
106 // Checking should succeed but add an error to the error map. 107 // Checking should succeed but add an error to the error map.
107 EXPECT_TRUE(CheckPolicySettings()); 108 EXPECT_TRUE(CheckPolicySettings());
108 EXPECT_EQ(1U, errors().size()); 109 EXPECT_EQ(1U, errors().size());
109 EXPECT_TRUE(key::kCookiesSessionOnlyForUrls == errors().begin()->first); 110 EXPECT_TRUE(key::kCookiesSessionOnlyForUrls == errors().begin()->first);
110 EXPECT_EQ(l10n_util::GetStringFUTF16(IDS_POLICY_OVERRIDDEN, 111 EXPECT_EQ(l10n_util::GetStringFUTF16(
111 ASCIIToUTF16(key::kRestoreOnStartup)), 112 IDS_POLICY_OVERRIDDEN,
113 base::ASCIIToUTF16(key::kRestoreOnStartup)),
112 errors().begin()->second); 114 errors().begin()->second);
113 } 115 }
114 116
115 TEST_F(RestoreOnStartupPolicyHandlerTest, 117 TEST_F(RestoreOnStartupPolicyHandlerTest,
116 CheckPolicySettings_RestoreLastSession_ClearDataOnExit) { 118 CheckPolicySettings_RestoreLastSession_ClearDataOnExit) {
117 // Specify the Last value and the Clear-Data-On-Exit value. 119 // Specify the Last value and the Clear-Data-On-Exit value.
118 SetPolicyValue( 120 SetPolicyValue(
119 key::kRestoreOnStartup, 121 key::kRestoreOnStartup,
120 new base::FundamentalValue(SessionStartupPref::kPrefValueLast)); 122 new base::FundamentalValue(SessionStartupPref::kPrefValueLast));
121 SetPolicyValue(key::kClearSiteDataOnExit, new base::FundamentalValue(true)); 123 SetPolicyValue(key::kClearSiteDataOnExit, new base::FundamentalValue(true));
122 // Checking should succeed but add an error to the error map. 124 // Checking should succeed but add an error to the error map.
123 EXPECT_TRUE(CheckPolicySettings()); 125 EXPECT_TRUE(CheckPolicySettings());
124 EXPECT_EQ(1U, errors().size()); 126 EXPECT_EQ(1U, errors().size());
125 EXPECT_TRUE(key::kClearSiteDataOnExit == errors().begin()->first); 127 EXPECT_TRUE(key::kClearSiteDataOnExit == errors().begin()->first);
126 EXPECT_EQ(l10n_util::GetStringFUTF16(IDS_POLICY_OVERRIDDEN, 128 EXPECT_EQ(l10n_util::GetStringFUTF16(
127 ASCIIToUTF16(key::kRestoreOnStartup)), 129 IDS_POLICY_OVERRIDDEN,
130 base::ASCIIToUTF16(key::kRestoreOnStartup)),
128 errors().begin()->second); 131 errors().begin()->second);
129 } 132 }
130 133
131 TEST_F(RestoreOnStartupPolicyHandlerTest, 134 TEST_F(RestoreOnStartupPolicyHandlerTest,
132 CheckPolicySettings_RestoreLastSession) { 135 CheckPolicySettings_RestoreLastSession) {
133 // Specify the Last value without the conflicts. 136 // Specify the Last value without the conflicts.
134 SetPolicyValue( 137 SetPolicyValue(
135 key::kRestoreOnStartup, 138 key::kRestoreOnStartup,
136 new base::FundamentalValue(SessionStartupPref::kPrefValueLast)); 139 new base::FundamentalValue(SessionStartupPref::kPrefValueLast));
137 // Checking should succeed with no errors. 140 // Checking should succeed with no errors.
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
279 EXPECT_TRUE(prefs().GetValue(prefs::kURLsToRestoreOnStartup, &url_result)); 282 EXPECT_TRUE(prefs().GetValue(prefs::kURLsToRestoreOnStartup, &url_result));
280 base::ListValue* url_list_result; 283 base::ListValue* url_list_result;
281 EXPECT_TRUE(url_result->GetAsList(&url_list_result)); 284 EXPECT_TRUE(url_result->GetAsList(&url_list_result));
282 EXPECT_EQ(1U, url_list_result->GetSize()); 285 EXPECT_EQ(1U, url_list_result->GetSize());
283 std::string expected_url; 286 std::string expected_url;
284 EXPECT_TRUE(url_list_result->GetString(0, &expected_url)); 287 EXPECT_TRUE(url_list_result->GetString(0, &expected_url));
285 EXPECT_EQ(std::string("http://foo.com"), expected_url); 288 EXPECT_EQ(std::string("http://foo.com"), expected_url);
286 } 289 }
287 290
288 } // namespace policy 291 } // namespace policy
OLDNEW
« no previous file with comments | « chrome/browser/sessions/better_session_restore_browsertest.cc ('k') | chrome/browser/sessions/session_types_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698