chrome/browser/spellchecker/spellcheck_message_filter_unittest.cc - Issue 120983002: Update some uses of UTF conversions in chrome/browser to use the base:: namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/spellchecker/spellcheck_message_filter_unittest.cc

Issue 120983002: Update some uses of UTF conversions in chrome/browser to use the base:: namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/spellchecker/spellcheck_message_filter_mac_unittest.cc ('k') | chrome/browser/spellchecker/spellcheck_platform_mac_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/spellchecker/spellcheck_message_filter_unittest.cc

diff --git a/chrome/browser/spellchecker/spellcheck_message_filter_unittest.cc b/chrome/browser/spellchecker/spellcheck_message_filter_unittest.cc

index 46952979a04e37b5b5d3d6663e7d3c75ded741e3..ecde185cea0df8cd37f65ee64bc9c60e83e51117 100644

--- a/chrome/browser/spellchecker/spellcheck_message_filter_unittest.cc

+++ b/chrome/browser/spellchecker/spellcheck_message_filter_unittest.cc

@@ -80,17 +80,17 @@ TEST(SpellCheckMessageFilterTest, OnTextCheckCompleteTestCustomDictionary) {

static const int kRouteId = 0;

static const int kCallbackId = 0;

static const std::vector<SpellCheckMarker> kMarkers;

- static const base::string16 kText = ASCIIToUTF16("Helllo warld.");

+ static const base::string16 kText = base::ASCIIToUTF16("Helllo warld.");

static const bool kSuccess = true;

static const SpellCheckResult::Decoration kDecoration =

SpellCheckResult::SPELLING;

static const int kLocation = 7;

static const int kLength = 5;

- static const base::string16 kReplacement = ASCIIToUTF16("world");

+ static const base::string16 kReplacement = base::ASCIIToUTF16("world");

std::vector<SpellCheckResult> results;

results.push_back(SpellCheckResult(

- SpellCheckResult::SPELLING, 0, 6, ASCIIToUTF16("Hello")));

+ SpellCheckResult::SPELLING, 0, 6, base::ASCIIToUTF16("Hello")));

results.push_back(

SpellCheckResult(kDecoration, kLocation, kLength, kReplacement));

@@ -124,14 +124,14 @@ TEST(SpellCheckMessageFilterTest, OnTextCheckCompleteTestCustomDictionary) {

TEST(SpellCheckMessageFilterTest, OnTextCheckCompleteTest) {

std::vector<SpellCheckResult> results;

results.push_back(SpellCheckResult(

- SpellCheckResult::SPELLING, 0, 6, ASCIIToUTF16("Hello")));

+ SpellCheckResult::SPELLING, 0, 6, base::ASCIIToUTF16("Hello")));

results.push_back(SpellCheckResult(

- SpellCheckResult::SPELLING, 7, 7, ASCIIToUTF16("world")));

+ SpellCheckResult::SPELLING, 7, 7, base::ASCIIToUTF16("world")));

scoped_refptr<TestingSpellCheckMessageFilter> filter(

new TestingSpellCheckMessageFilter);

filter->OnTextCheckComplete(1, 1, std::vector<SpellCheckMarker>(),

- true, ASCIIToUTF16("Helllo walrd"), results);

+ true, base::ASCIIToUTF16("Helllo walrd"), results);

EXPECT_EQ(static_cast<size_t>(1), filter->sent_messages.size());

int sent_identifier = -1;