chrome/browser/tab_contents/render_view_context_menu.cc - Issue 120983002: Update some uses of UTF conversions in chrome/browser to use the base:: namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/tab_contents/render_view_context_menu.cc

Issue 120983002: Update some uses of UTF conversions in chrome/browser to use the base:: namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/tab_contents/render_view_context_menu.h ('k') | chrome/browser/tab_contents/spelling_menu_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/tab_contents/render_view_context_menu.cc

diff --git a/chrome/browser/tab_contents/render_view_context_menu.cc b/chrome/browser/tab_contents/render_view_context_menu.cc

index 9d22b4c0f8c667dbbbdd2f67172dc7feda763142..8dc404072037e5893a183e466cf3d0d9701f9e00 100644

--- a/chrome/browser/tab_contents/render_view_context_menu.cc

+++ b/chrome/browser/tab_contents/render_view_context_menu.cc

@@ -372,7 +372,7 @@ void DevToolsInspectElementAt(RenderViewHost* rvh, int x, int y) {

// Helper function to escape "&" as "&&".

void EscapeAmpersands(base::string16* text) {

const char16 ampersand[] = {'&', 0};

- base::ReplaceChars(*text, ampersand, ASCIIToUTF16("&&"), text);

+ base::ReplaceChars(*text, ampersand, base::ASCIIToUTF16("&&"), text);

}

} // namespace

@@ -1016,7 +1016,7 @@ void RenderViewContextMenu::AppendSearchProvider() {

return;

base::ReplaceChars(params_.selection_text, AutocompleteMatch::kInvalidChars,

- ASCIIToUTF16(" "), &params_.selection_text);

+ base::ASCIIToUTF16(" "), &params_.selection_text);

AutocompleteMatch match;

AutocompleteClassifierFactory::GetForProfile(profile_)->Classify(

« no previous file with comments | « chrome/browser/tab_contents/render_view_context_menu.h ('k') | chrome/browser/tab_contents/spelling_menu_observer.cc » ('j') | no next file with comments »