media: Support RendererFactory in MojoMediaClient.

media: Support RendererFactory in MojoMediaClient.

The embedder can choose to use a customized RendererFactory, or use RendererImpl
with customized audio/video decoders. By default, we use DefaultRendererFactory.

Also replace LogCB with MediaLog in various places.

BUG=495273, 499628
Committed: https://crrev.com/c4e00d2b1bbf031a925e1141344c8da3d48462a2
Cr-Commit-Position: refs/heads/master@{#337888}

[xhwang, 2015-07-08 01:03:29]

xhwang@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[xhwang, 2015-07-08 01:03:30]

PTAL

[xhwang, 2015-07-08 16:58:16]

https://codereview.chromium.org/1209363004/diff/20001/media/BUILD.gn
File media/BUILD.gn (right):

https://codereview.chromium.org/1209363004/diff/20001/media/BUILD.gn#newcode352
media/BUILD.gn:352: "filters/opus_audio_decoder.h",
What's the reason we disable opus audio decoder on Android?

[DaleCurtis, 2015-07-08 18:22:48]

lgtm

https://codereview.chromium.org/1209363004/diff/20001/media/BUILD.gn
File media/BUILD.gn (right):

https://codereview.chromium.org/1209363004/diff/20001/media/BUILD.gn#newcode352
media/BUILD.gn:352: "filters/opus_audio_decoder.h",
On 2015/07/08 16:58:16, xhwang wrote:
> What's the reason we disable opus audio decoder on Android?

I don't think any decoders should be enabled today on android?

[xhwang, 2015-07-08 18:39:09]

https://codereview.chromium.org/1209363004/diff/20001/media/BUILD.gn
File media/BUILD.gn (right):

https://codereview.chromium.org/1209363004/diff/20001/media/BUILD.gn#newcode352
media/BUILD.gn:352: "filters/opus_audio_decoder.h",
On 2015/07/08 18:22:48, DaleCurtis wrote:
> On 2015/07/08 16:58:16, xhwang wrote:
> > What's the reason we disable opus audio decoder on Android?
> 
> I don't think any decoders should be enabled today on android?

There are a lot of classes (e.g. RendererImpl, VideoRendererImpl, etc) that we
don't use on Android but are enabled on all platforms. If they end up not being
used on a platform, the code will be stripped out. So it seems to me we should
only disable code that will NOT work on a platform, not code that is not enabled
or needed on/by a platform?

[xhwang, 2015-07-08 18:39:22]

The CQ bit was checked by xhwang@chromium.org

[commit-bot: I haz the power, 2015-07-08 18:40:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1209363004/20001

[DaleCurtis, 2015-07-08 18:44:17]

https://codereview.chromium.org/1209363004/diff/20001/media/BUILD.gn
File media/BUILD.gn (right):

https://codereview.chromium.org/1209363004/diff/20001/media/BUILD.gn#newcode352
media/BUILD.gn:352: "filters/opus_audio_decoder.h",
On 2015/07/08 18:39:09, xhwang wrote:
> On 2015/07/08 18:22:48, DaleCurtis wrote:
> > On 2015/07/08 16:58:16, xhwang wrote:
> > > What's the reason we disable opus audio decoder on Android?
> > 
> > I don't think any decoders should be enabled today on android?
> 
> There are a lot of classes (e.g. RendererImpl, VideoRendererImpl, etc) that we
> don't use on Android but are enabled on all platforms. If they end up not
being
> used on a platform, the code will be stripped out. So it seems to me we should
> only disable code that will NOT work on a platform, not code that is not
enabled
> or needed on/by a platform?

If by not used you mean they will not be compiled via -= [sources] blocks then
that's fine with me. I don't think we should rely on the linker to strip dead
unused code post-compilation though.

[xhwang, 2015-07-08 18:55:22]

On 2015/07/08 18:44:17, DaleCurtis wrote:
> https://codereview.chromium.org/1209363004/diff/20001/media/BUILD.gn
> File media/BUILD.gn (right):
> 
>
https://codereview.chromium.org/1209363004/diff/20001/media/BUILD.gn#newcode352
> media/BUILD.gn:352: "filters/opus_audio_decoder.h",
> On 2015/07/08 18:39:09, xhwang wrote:
> > On 2015/07/08 18:22:48, DaleCurtis wrote:
> > > On 2015/07/08 16:58:16, xhwang wrote:
> > > > What's the reason we disable opus audio decoder on Android?
> > > 
> > > I don't think any decoders should be enabled today on android?
> > 
> > There are a lot of classes (e.g. RendererImpl, VideoRendererImpl, etc) that
we
> > don't use on Android but are enabled on all platforms. If they end up not
> being
> > used on a platform, the code will be stripped out. So it seems to me we
should
> > only disable code that will NOT work on a platform, not code that is not
> enabled
> > or needed on/by a platform?
> 
> If by not used you mean they will not be compiled via -= [sources] blocks then
> that's fine with me. I don't think we should rely on the linker to strip dead
> unused code post-compilation though.

By "not used" I meant "not called anywhere in the code; or dead code". I think
we are already relying on the linker to strip dead used code today. If we don't
want to rely on this, we probably should block more files (using -= [sources])
in the huge list [1] on Android.

[1]
https://code.google.com/p/chromium/codesearch#chromium/src/media/media.gyp&l=75

[commit-bot: I haz the power, 2015-07-08 19:55:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-07-08 19:56:29]

Patchset 2 (id:??) landed as
https://crrev.com/c4e00d2b1bbf031a925e1141344c8da3d48462a2
Cr-Commit-Position: refs/heads/master@{#337888}