media: Support RendererFactory in MojoMediaClient.

media/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/android/config.gni")
 import("//build/config/arm.gni")
 import("//build/config/features.gni")
 import("//build/config/linux/pkg_config.gni")
 import("//build/config/ui.gni")
 import("//media/media_options.gni")
@@ skipping 178 matching lines @@
     "formats/webm/webm_stream_parser.cc",
     "formats/webm/webm_stream_parser.h",
     "formats/webm/webm_tracks_parser.cc",
     "formats/webm/webm_tracks_parser.h",
     "formats/webm/webm_video_client.cc",
     "formats/webm/webm_video_client.h",
     "formats/webm/webm_webvtt_parser.cc",
     "formats/webm/webm_webvtt_parser.h",
     "renderers/audio_renderer_impl.cc",
     "renderers/audio_renderer_impl.h",
+    "renderers/default_renderer_factory.cc",
+    "renderers/default_renderer_factory.h",
     "renderers/gpu_video_accelerator_factories.h",
     "renderers/renderer_impl.cc",
     "renderers/renderer_impl.h",
     "renderers/video_renderer_impl.cc",
     "renderers/video_renderer_impl.h",
     "video/capture/fake_video_capture_device.cc",
     "video/capture/fake_video_capture_device.h",
     "video/capture/fake_video_capture_device_factory.cc",
     "video/capture/fake_video_capture_device_factory.h",
     "video/capture/file_video_capture_device.cc",
@@ skipping 131 matching lines @@
     ]
     deps += [
       "//media/base/android",
       "//media/base/android:media_jni_headers",
       "//media/base/android:video_capture_jni_headers",
     ]
     allow_circular_includes_from = [ "//media/base/android" ]
   } else {
     sources += [
       "filters/opus_audio_decoder.cc",
       "filters/opus_audio_decoder.h",

[xhwang, 2015/07/08 16:58:16]

What's the reason we disable opus audio decoder on Android?

[DaleCurtis, 2015/07/08 18:22:48]

I don't think any decoders should be enabled today on android?

[xhwang, 2015/07/08 18:39:09]

There are a lot of classes (e.g. RendererImpl, VideoRendererImpl, etc) that we
don't use on Android but are enabled on all platforms. If they end up not being
used on a platform, the code will be stripped out. So it seems to me we should
only disable code that will NOT work on a platform, not code that is not enabled
or needed on/by a platform?

[DaleCurtis, 2015/07/08 18:44:16]

If by not used you mean they will not be compiled via -= [sources] blocks then
that's fine with me. I don't think we should rely on the linker to strip dead
unused code post-compilation though.

-      "renderers/default_renderer_factory.cc",
-      "renderers/default_renderer_factory.h",
     ]
   }
 
   if (current_cpu != "arm" && is_chromeos) {
     sources += [
       "filters/h264_bitstream_buffer.cc",
       "filters/h264_bitstream_buffer.h",
     ]
   }
 
@@ skipping 400 matching lines @@
       "//media/base:test_support",
       "//media/test:pipeline_integration_tests",
       "//testing/gmock",
       "//testing/gtest",
       "//third_party/ffmpeg",
       "//ui/gfx/geometry",
       "//ui/gfx:test_support",
     ]
   }
 }