Chromium Code Reviews

Issue 12090081: Add a Pub validator for READMEs that are invalid utf-8. (Closed)

Created:
7 years, 10 months ago by nweiz
Modified:
7 years, 10 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add a Pub validator for READMEs that are invalid utf-8. BUG=7045 Committed: https://code.google.com/p/dart/source/detail?r=17948

Patch Set 1 #

Patch Set 2 : Fix everything #

Patch Set 3 : Actually use the validator. #

Total comments: 16

Patch Set 4 : Code review changes #

Unified diffs Side-by-side diffs Stats (+125 lines, -10 lines)
utils/pub/io.dart View 2 chunks +24 lines, -0 lines 0 comments
utils/pub/package.dart View 2 chunks +22 lines, -0 lines 0 comments
utils/pub/validator.dart View 2 chunks +3 lines, -1 line 0 comments
A utils/pub/validator/utf8_readme.dart View 1 chunk +39 lines, -0 lines 0 comments
utils/tests/pub/test_pub.dart View 5 chunks +18 lines, -9 lines 0 comments
utils/tests/pub/validator_test.dart View 4 chunks +19 lines, -0 lines 0 comments

Messages

Total messages: 4 (0 generated)
nweiz
7 years, 10 months ago (2013-01-30 23:46:45 UTC) #1
Bob Nystrom
https://codereview.chromium.org/12090081/diff/4006/utils/pub/entrypoint.dart File utils/pub/entrypoint.dart (right): https://codereview.chromium.org/12090081/diff/4006/utils/pub/entrypoint.dart#newcode63 utils/pub/entrypoint.dart:63: /// chosen. How about moving this to Package? It's ...
7 years, 10 months ago (2013-01-31 19:08:29 UTC) #2
nweiz
https://codereview.chromium.org/12090081/diff/4006/utils/pub/entrypoint.dart File utils/pub/entrypoint.dart (right): https://codereview.chromium.org/12090081/diff/4006/utils/pub/entrypoint.dart#newcode63 utils/pub/entrypoint.dart:63: /// chosen. On 2013/01/31 19:08:29, Bob Nystrom wrote: > ...
7 years, 10 months ago (2013-01-31 21:39:10 UTC) #3
Bob Nystrom
7 years, 10 months ago (2013-01-31 21:44:49 UTC) #4 
LGTM

Powered by Google App Engine