Add a Pub validator for READMEs that are invalid utf-8.

utils/pub/io.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Helper functionality to make working with IO easier.
 library io;
 
 import 'dart:async';
 import 'dart:io';
 import 'dart:isolate';
@@ skipping 67 matching lines @@
       (contents) {
         // Sanity check: don't spew a huge file.
         if (contents.length < 1024 * 1024) {
           return "Read $path. Contents:\n$contents";
         } else {
           return "Read ${contents.length} characters from $path.";
         }
       });
 }
 
+/// Reads the contents of the binary file [file], which can either be a [String]
+/// or a [File].
+Future<List<int>> readByteFile(file) {

[Bob Nystrom, 2013/01/31 19:08:29]

"Byte" -> "Binary"?

"ByteFile" reads strangely to me.

[nweiz, 2013/01/31 21:39:10]

Done.

+  var path = _getPath(file);
+  return log.ioAsync("Reading byte file $path.",
+      new File(path).readAsBytes(),

[Bob Nystrom, 2013/01/31 19:08:29]

Feel free to make this sync if you prefer.

[nweiz, 2013/01/31 21:39:10]

Done.

+      (contents) => "Read ${contents.length} bytes from $path.");
+}
+
 /// Creates [file] (which can either be a [String] or a [File]), and writes
 /// [contents] to it. Completes when the file is written and closed.
 ///
 /// If [dontLogContents] is true, the contents of the file will never be logged.
 Future<File> writeTextFile(file, String contents, {dontLogContents: false}) {
   var path = _getPath(file);
   file = new File(path);
 
   // Sanity check: don't spew a huge file.
   log.io("Writing ${contents.length} characters to text file $path.");
   if (!dontLogContents && contents.length < 1024 * 1024) {
     log.fine("Contents:\n$contents");
   }
 
   return file.open(FileMode.WRITE).then((opened) {
     return opened.writeString(contents).then((ignore) {
         return opened.close().then((_) {
           log.fine("Wrote text file $path.");
           return file;
         });
     });
   });
 }
 
+/// Creates [file] (which can either be a [String] or a [File]), and writes
+/// [contents] to it. Completes when the file is written and closed.
+Future<File> writeByteFile(file, List<int> contents) {

[Bob Nystrom, 2013/01/31 19:08:29]

Byte -> Binary.

[nweiz, 2013/01/31 21:39:10]

Done.

+  var path = _getPath(file);
+  file = new File(path);
+
+  log.io("Writing ${contents.length} characters to binary file $path.");

[Bob Nystrom, 2013/01/31 19:08:29]

"characters" -> "bytes".

[nweiz, 2013/01/31 21:39:10]

Done.

+  return file.open(FileMode.WRITE).then((opened) {
+    return opened.writeList(contents, 0, contents.length)
+        .then((_) => opened.close());
+  }).then((_) {
+    log.fine("Wrote text file $path.");
+    return file;
+  });

[Bob Nystrom, 2013/01/31 19:08:29]

then() then() then()

Make this sync?

[nweiz, 2013/01/31 21:39:10]

Done.

+}
+
 /// Asynchronously deletes [file], which can be a [String] or a [File]. Returns
 /// a [Future] that completes when the deletion is done.
 Future<File> deleteFile(file) {
   var path = _getPath(file);
   return log.ioAsync("delete file $path",
       new File(path).delete());
 }
 
 /// Writes [stream] to a new file at [path], which may be a [String] or a
 /// [File]. Will replace any file already at that path. Completes when the file
@@ skipping 844 matching lines @@
 Directory _getDirectory(entry) {
   if (entry is Directory) return entry;
   return new Directory(entry);
 }
 
 /// Gets a [Uri] for [uri], which can either already be one, or be a [String].
 Uri _getUri(uri) {
   if (uri is Uri) return uri;
   return Uri.parse(uri);
 }