Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1272)

Unified Diff: utils/pub/validator/utf8_readme.dart

Issue 12090081: Add a Pub validator for READMEs that are invalid utf-8. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Code review changes Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « utils/pub/validator.dart ('k') | utils/tests/pub/test_pub.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/pub/validator/utf8_readme.dart
diff --git a/utils/pub/validator/utf8_readme.dart b/utils/pub/validator/utf8_readme.dart
new file mode 100644
index 0000000000000000000000000000000000000000..e586230521eb5448562268ed68e357a737e96cce
--- /dev/null
+++ b/utils/pub/validator/utf8_readme.dart
@@ -0,0 +1,39 @@
+// Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+library utf8_readme_validator;
+
+import 'dart:async';
+import 'dart:utf';
+
+import '../../../pkg/path/lib/path.dart' as path;
+
+import '../entrypoint.dart';
+import '../io.dart';
+import '../utils.dart';
+import '../validator.dart';
+
+/// Validates that a package's README is valid utf-8.
+class Utf8ReadmeValidator extends Validator {
+ Utf8ReadmeValidator(Entrypoint entrypoint)
+ : super(entrypoint);
+
+ Future validate() {
+ return entrypoint.root.readmePath.then((readme) {
+ if (readme == null) return;
+ var bytes = readBinaryFile(readme);
+ try {
+ // The second and third arguments here are the default values. The
+ // fourth tells [decodeUtf8] to throw an ArgumentError if `bytes` isn't
+ // valid utf-8.
+ decodeUtf8(bytes, 0, null, null);
+ } on ArgumentError catch (_) {
+ warnings.add("$readme contains invalid UTF-8.\n"
+ "This will cause it to be displayed incorrectly on "
+ "pub.dartlang.org.");
+ }
+ });
+ }
+}
+
« no previous file with comments | « utils/pub/validator.dart ('k') | utils/tests/pub/test_pub.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698