Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Side by Side Diff: utils/pub/validator/utf8_readme.dart

Issue 12090081: Add a Pub validator for READMEs that are invalid utf-8. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Code review changes Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « utils/pub/validator.dart ('k') | utils/tests/pub/test_pub.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file.
4
5 library utf8_readme_validator;
6
7 import 'dart:async';
8 import 'dart:utf';
9
10 import '../../../pkg/path/lib/path.dart' as path;
11
12 import '../entrypoint.dart';
13 import '../io.dart';
14 import '../utils.dart';
15 import '../validator.dart';
16
17 /// Validates that a package's README is valid utf-8.
18 class Utf8ReadmeValidator extends Validator {
19 Utf8ReadmeValidator(Entrypoint entrypoint)
20 : super(entrypoint);
21
22 Future validate() {
23 return entrypoint.root.readmePath.then((readme) {
24 if (readme == null) return;
25 var bytes = readBinaryFile(readme);
26 try {
27 // The second and third arguments here are the default values. The
28 // fourth tells [decodeUtf8] to throw an ArgumentError if `bytes` isn't
29 // valid utf-8.
30 decodeUtf8(bytes, 0, null, null);
31 } on ArgumentError catch (_) {
32 warnings.add("$readme contains invalid UTF-8.\n"
33 "This will cause it to be displayed incorrectly on "
34 "pub.dartlang.org.");
35 }
36 });
37 }
38 }
39
OLDNEW
« no previous file with comments | « utils/pub/validator.dart ('k') | utils/tests/pub/test_pub.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698