Presentation API: ignore presentation id passed to startSession().

Presentation API: ignore presentation id passed to startSession().

The presentation id will soon no longer be passed by Blink.

This is part of a suite of three CLs:
1. <this>
2. https://codereview.chromium.org/1225523002
3. https://codereview.chromium.org/1221093004

BUG=502047
Committed: https://crrev.com/ff9e39863a692987bdbfe5099797369f20d5d476
Cr-Commit-Position: refs/heads/master@{#337868}

[mlamouri (slow - plz ping), 2015-07-02 17:32:19]

mlamouri@chromium.org changed reviewers:
+ avayvod@chromium.org, mfoltz@chromium.org

[whywhat, 2015-07-02 19:54:31]

You need to update the PresentationServiceImplUnittest as part of the change (it
fails to compile).

Otherwise LGTM

https://codereview.chromium.org/1208083004/diff/1/content/common/presentation...
File content/common/presentation/presentation_service.mojom (right):

https://codereview.chromium.org/1208083004/diff/1/content/common/presentation...
content/common/presentation/presentation_service.mojom:76: // The presentation
id is always returned along with the initialized
Perhaps, you should mention that the presentation id is always generated by the
UA here?
I.e. replace the sentence with "The presentation id returned in |sessionInfo| on
success is generated by the UA."

https://codereview.chromium.org/1208083004/diff/1/content/common/presentation...
content/common/presentation/presentation_service.mojom:97: 
what's this diff?

https://codereview.chromium.org/1208083004/diff/1/content/public/browser/pres...
File content/public/browser/presentation_service_delegate.h (left):

https://codereview.chromium.org/1208083004/diff/1/content/public/browser/pres...
content/public/browser/presentation_service_delegate.h:110: // as the ID of the
presentation. If empty, the default presentation ID
Perhaps you want to leave the comment about the default presentation id and
generated presentation id in here out of the parameters list?

[mark a. foltz, 2015-07-06 21:00:57]

Please update unit tests

https://codereview.chromium.org/1208083004/diff/1/chrome/browser/media/router...
File chrome/browser/media/router/presentation_service_delegate_impl.cc (right):

https://codereview.chromium.org/1208083004/diff/1/chrome/browser/media/router...
chrome/browser/media/router/presentation_service_delegate_impl.cc:560:
std::string presentation_id =
The code path to retrieve the default presentation ID from the frame should also
be removed.

However, since this API is going to be changing anyway, it might be cleaner to
do it in a separate patch that implements the new API.

So, ignoring the frame-provided presentation ID, and adding a TODO would be fine
as well.

[mlamouri (slow - plz ping), 2015-07-08 14:37:09]

https://codereview.chromium.org/1208083004/diff/1/chrome/browser/media/router...
File chrome/browser/media/router/presentation_service_delegate_impl.cc (right):

https://codereview.chromium.org/1208083004/diff/1/chrome/browser/media/router...
chrome/browser/media/router/presentation_service_delegate_impl.cc:560:
std::string presentation_id =
On 2015/07/06 at 21:00:57, mark a. foltz wrote:
> The code path to retrieve the default presentation ID from the frame should
also be removed.
> 
> However, since this API is going to be changing anyway, it might be cleaner to
do it in a separate patch that implements the new API.
> 
> So, ignoring the frame-provided presentation ID, and adding a TODO would be
fine as well.

I will keep it as-is and add a TODO saying that we will remove it.

https://codereview.chromium.org/1208083004/diff/1/content/common/presentation...
File content/common/presentation/presentation_service.mojom (right):

https://codereview.chromium.org/1208083004/diff/1/content/common/presentation...
content/common/presentation/presentation_service.mojom:76: // The presentation
id is always returned along with the initialized
On 2015/07/02 at 19:54:31, whywhat wrote:
> Perhaps, you should mention that the presentation id is always generated by
the UA here?
> I.e. replace the sentence with "The presentation id returned in |sessionInfo|
on success is generated by the UA."

Done.

https://codereview.chromium.org/1208083004/diff/1/content/common/presentation...
content/common/presentation/presentation_service.mojom:97: 
On 2015/07/02 at 19:54:31, whywhat wrote:
> what's this diff?

Can't find that in my diff locally.

https://codereview.chromium.org/1208083004/diff/1/content/public/browser/pres...
File content/public/browser/presentation_service_delegate.h (left):

https://codereview.chromium.org/1208083004/diff/1/content/public/browser/pres...
content/public/browser/presentation_service_delegate.h:110: // as the ID of the
presentation. If empty, the default presentation ID
On 2015/07/02 at 19:54:31, whywhat wrote:
> Perhaps you want to leave the comment about the default presentation id and
generated presentation id in here out of the parameters list?

Done.

[mlamouri (slow - plz ping), 2015-07-08 16:34:06]

The CQ bit was checked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2015-07-08 16:34:07]

The patchset sent to the CQ was uploaded after l-g-t-m from avayvod@chromium.org
Link to the patchset: https://codereview.chromium.org/1208083004/#ps20001
(title: "review comments")

[commit-bot: I haz the power, 2015-07-08 16:35:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1208083004/20001

[commit-bot: I haz the power, 2015-07-08 16:44:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-08 16:44:20]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[mlamouri (slow - plz ping), 2015-07-08 16:46:14]

Oups. mfoltz@, PTAL.

[mark a. foltz, 2015-07-08 17:48:37]

lgtm

[mlamouri (slow - plz ping), 2015-07-08 18:34:46]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2015-07-08 18:35:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1208083004/20001

[commit-bot: I haz the power, 2015-07-08 18:41:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-07-08 18:42:20]

Patchset 2 (id:??) landed as
https://crrev.com/ff9e39863a692987bdbfe5099797369f20d5d476
Cr-Commit-Position: refs/heads/master@{#337868}