Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3360)

Unified Diff: chrome/browser/media/router/presentation_service_delegate_impl.cc

Issue 1208083004: Presentation API: ignore presentation id passed to startSession(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/presentation_service_delegate_impl.cc
diff --git a/chrome/browser/media/router/presentation_service_delegate_impl.cc b/chrome/browser/media/router/presentation_service_delegate_impl.cc
index d49c6f1c36fb13b74b5310bc8a68fd5255499e4d..3e9978f52e8cdaf460de04982d727ce9950d2294 100644
--- a/chrome/browser/media/router/presentation_service_delegate_impl.cc
+++ b/chrome/browser/media/router/presentation_service_delegate_impl.cc
@@ -548,7 +548,6 @@ void PresentationServiceDelegateImpl::StartSession(
int render_process_id,
int render_frame_id,
const std::string& presentation_url,
- const std::string& presentation_id,
const PresentationSessionSuccessCallback& success_cb,
const PresentationSessionErrorCallback& error_cb) {
if (presentation_url.empty() || !IsValidPresentationUrl(presentation_url)) {
@@ -557,16 +556,16 @@ void PresentationServiceDelegateImpl::StartSession(
return;
}
RenderFrameHostId render_frame_host_id(render_process_id, render_frame_id);
- std::string final_presentation_id =
- presentation_id.empty()
- ? frame_manager_->GetDefaultPresentationId(render_frame_host_id)
- : presentation_id;
- if (final_presentation_id.empty())
- // TODO(imcheng): Remove presentation_id argument entirely if required
- // by Presentation API spec.
- final_presentation_id = base::GenerateGUID();
+
+ // TODO(mlamouri,avayvod): don't use the default presentation id provided by
+ // the frame when we implement the new default presentation model.
+ std::string presentation_id =
+ frame_manager_->GetDefaultPresentationId(render_frame_host_id);
+ if (presentation_id.empty())
+ presentation_id = base::GenerateGUID();
+
scoped_ptr<CreateSessionRequest> context(new CreateSessionRequest(
- presentation_url, final_presentation_id,
+ presentation_url, presentation_id,
GetLastCommittedURLForFrame(render_frame_host_id),
base::Bind(&PresentationServiceDelegateImpl::OnStartSessionSucceeded,
weak_factory_.GetWeakPtr(), render_process_id, render_frame_id,

Powered by Google App Engine
This is Rietveld 408576698