Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1225523002: Presentation API: startSession() no longer takes a presentation id. (Closed)

Created:
5 years, 5 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 5 months ago
Reviewers:
mark a. foltz, whywhat
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Presentation API: startSession() no longer takes a presentation id. This is part of a suite of three CLs: 1. https://codereview.chromium.org/1208083004 2. <this> 3. https://codereview.chromium.org/1221093004 BUG=502047 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198635

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M Source/modules/presentation/Presentation.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/presentation/Presentation.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/presentation/Presentation.idl View 1 1 chunk +1 line, -2 lines 0 comments Download
M public/platform/modules/presentation/WebPresentationClient.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
mlamouri (slow - plz ping)
5 years, 5 months ago (2015-07-02 17:37:06 UTC) #2
whywhat
lgtm
5 years, 5 months ago (2015-07-02 21:56:32 UTC) #3
mark a. foltz
lgtm
5 years, 5 months ago (2015-07-06 20:48:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225523002/1
5 years, 5 months ago (2015-07-08 10:01:32 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/49913) mac_blink_rel on tryserver.blink (JOB_FAILED, ...
5 years, 5 months ago (2015-07-08 10:04:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225523002/20001
5 years, 5 months ago (2015-07-09 21:00:02 UTC) #12
commit-bot: I haz the power
5 years, 5 months ago (2015-07-09 22:29:01 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198635

Powered by Google App Engine
This is Rietveld 408576698