Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 1221093004: Presentation API: remove stall PresentationDispatcher::startSession(). (Closed)

Created:
5 years, 5 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 5 months ago
Reviewers:
mark a. foltz, whywhat
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@presentation_startsession_noid
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Presentation API: remove stall PresentationDispatcher::startSession(). This is part of a suite of three CLs: 1. https://codereview.chromium.org/1208083004 2. https://codereview.chromium.org/1225523002 3. <this> BUG=502047 Committed: https://crrev.com/3b02fa855dfb16e0b127e1a9fc70e84484569568 Cr-Commit-Position: refs/heads/master@{#338271}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -12 lines) Patch
M content/renderer/presentation/presentation_dispatcher.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/presentation/presentation_dispatcher.cc View 1 2 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
mlamouri (slow - plz ping)
5 years, 5 months ago (2015-07-02 17:39:13 UTC) #2
whywhat
lgtm
5 years, 5 months ago (2015-07-02 21:56:51 UTC) #3
mark a. foltz
lgtm
5 years, 5 months ago (2015-07-06 20:47:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1221093004/20001
5 years, 5 months ago (2015-07-10 10:10:15 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-10 11:00:43 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 11:01:47 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3b02fa855dfb16e0b127e1a9fc70e84484569568
Cr-Commit-Position: refs/heads/master@{#338271}

Powered by Google App Engine
This is Rietveld 408576698