Windows precompiled header support in GN

Windows precompiled header support in GN.

Introduces aprecompiled_header_type flag on a tool to say whether it supports precompiled headers, and flags on configs/targets that allow one to specify which header is precompiled.

This does not implement GCC precompiled headers, but the type flag will allow future expansion (the implementation will be mostly separate).

Renames SOURCE_CC to SOURCE_CPP to avoid confusion with Toolchain::TYPE_CC (which is actually the C compiler).

BUG=297678
Committed: https://crrev.com/3dab5fe87ddb0efe646f6ab393ab07533d75237d
Cr-Commit-Position: refs/heads/master@{#336674}

[scottmg, 2015-06-26 22:30:12]

scottmg@chromium.org changed reviewers:
+ scottmg@chromium.org

[scottmg, 2015-06-26 22:30:13]

https://codereview.chromium.org/1207903002/diff/60001/tools/gn/config_values_...
File tools/gn/config_values_generator.cc (right):

https://codereview.chromium.org/1207903002/diff/60001/tools/gn/config_values_...
tools/gn/config_values_generator.cc:99: "against your #includes rather than a
GN-style file name.");
"match exactly against your #includes" isn't too clear

https://codereview.chromium.org/1207903002/diff/60001/tools/gn/ninja_binary_t...
File tools/gn/ninja_binary_target_writer.cc (right):

https://codereview.chromium.org/1207903002/diff/60001/tools/gn/ninja_binary_t...
tools/gn/ninja_binary_target_writer.cc:323: out_ << " /Yc" <<
target_->config_values().precompiled_header();
Don't you need /Fp here somewhere?

https://codereview.chromium.org/1207903002/diff/60001/tools/gn/source_file_ty...
File tools/gn/source_file_type.h (right):

https://codereview.chromium.org/1207903002/diff/60001/tools/gn/source_file_ty...
tools/gn/source_file_type.h:16: SOURCE_CC,
_CPP might be better to be less confusing with toolchain TYPE_CC.

[brettw, 2015-06-29 21:36:11]

Ready for real review.

https://codereview.chromium.org/1207903002/diff/60001/tools/gn/ninja_binary_t...
File tools/gn/ninja_binary_target_writer.cc (right):

https://codereview.chromium.org/1207903002/diff/60001/tools/gn/ninja_binary_t...
tools/gn/ninja_binary_target_writer.cc:323: out_ << " /Yc" <<
target_->config_values().precompiled_header();
On 2015/06/26 22:30:13, scottmg wrote:
> Don't you need /Fp here somewhere?

No because this line will look like:
  cflags_cc = ${cflags_cc} /Ycfoo.h
and the old value of cflags_cc has all the other flags in it.

https://codereview.chromium.org/1207903002/diff/60001/tools/gn/source_file_ty...
File tools/gn/source_file_type.h (right):

https://codereview.chromium.org/1207903002/diff/60001/tools/gn/source_file_ty...
tools/gn/source_file_type.h:16: SOURCE_CC,
On 2015/06/26 22:30:13, scottmg wrote:
> _CPP might be better to be less confusing with toolchain TYPE_CC.

Good idea, I found this confusing myself.

https://codereview.chromium.org/1207903002/diff/100001/tools/gn/ninja_binary_...
File tools/gn/ninja_binary_target_writer.cc (right):

https://codereview.chromium.org/1207903002/diff/100001/tools/gn/ninja_binary_...
tools/gn/ninja_binary_target_writer.cc:102: bool GetOutputFilesForSource(const
Target* target,
This was moved (unchanged) from the bottom of the file. I moved it out of the
class since it doesn't depend on anything in it

https://codereview.chromium.org/1207903002/diff/100001/tools/gn/ninja_binary_...
tools/gn/ninja_binary_target_writer.cc:247: // The input dependencies will be an
order-only dependency. This will cause
This comment was moved unchanged from below.

https://codereview.chromium.org/1207903002/diff/100001/tools/gn/ninja_binary_...
tools/gn/ninja_binary_target_writer.cc:488: void
NinjaBinaryTargetWriter::WriteCompilerBuildLine(
This was factored out of WriteSources so it could be shared with the new PCH
compile.

https://codereview.chromium.org/1207903002/diff/100001/tools/gn/ninja_binary_...
File tools/gn/ninja_binary_target_writer_unittest.cc (left):

https://codereview.chromium.org/1207903002/diff/100001/tools/gn/ninja_binary_...
tools/gn/ninja_binary_target_writer_unittest.cc:41: "cflags_c =\n"
These got deleted because there are no sources of that type.

[brettw, 2015-06-29 21:36:16]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-29 21:36:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1207903002/100001

[scottmg, 2015-06-29 21:49:17]

lgtm

https://codereview.chromium.org/1207903002/diff/100001/build/config/BUILD.gn
File build/config/BUILD.gn (right):

https://codereview.chromium.org/1207903002/diff/100001/build/config/BUILD.gn#...
build/config/BUILD.gn:408: # Reccommend precompiled headers for targets with
more than 50 .cc files.
"Recommend"

https://codereview.chromium.org/1207903002/diff/100001/tools/gn/config_values...
File tools/gn/config_values_generator.cc (right):

https://codereview.chromium.org/1207903002/diff/100001/tools/gn/config_values...
tools/gn/config_values_generator.cc:99: "the your #include lines rather than a
GN-style file name.\n");
"the" or "your" but not both.

https://codereview.chromium.org/1207903002/diff/100001/tools/gn/ninja_binary_...
File tools/gn/ninja_binary_target_writer.cc (right):

https://codereview.chromium.org/1207903002/diff/100001/tools/gn/ninja_binary_...
tools/gn/ninja_binary_target_writer.cc:196: // teh tool if there are more than
one.
teh

https://codereview.chromium.org/1207903002/diff/100001/tools/gn/ninja_binary_...
File tools/gn/ninja_binary_target_writer.h (right):

https://codereview.chromium.org/1207903002/diff/100001/tools/gn/ninja_binary_...
tools/gn/ninja_binary_target_writer.h:34: // has_precompiled_headers is set when
this substitution matches a tool thpe
thpe->type

https://codereview.chromium.org/1207903002/diff/100001/tools/gn/ninja_binary_...
tools/gn/ninja_binary_target_writer.h:35: // that supports precompiled headers,
and this target support precompiled
second "support" -> "supports"

[brettw, 2015-06-29 21:53:56]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-06-29 21:53:56]

The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/1207903002/#ps120001
(title: "Scott's grammar nits")

[commit-bot: I haz the power, 2015-06-29 21:55:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1207903002/120001

[commit-bot: I haz the power, 2015-06-29 23:00:22]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-06-29 23:01:30]

Patchset 7 (id:??) landed as
https://crrev.com/3dab5fe87ddb0efe646f6ab393ab07533d75237d
Cr-Commit-Position: refs/heads/master@{#336674}