Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: tools/gn/test_with_scope.cc

Issue 1207903002: Windows precompiled header support in GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Scott's grammar nits Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/test_with_scope.h ('k') | tools/gn/tool.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/test_with_scope.cc
diff --git a/tools/gn/test_with_scope.cc b/tools/gn/test_with_scope.cc
index 847af62e2787905ac83e9e4e3546372810bf9cff..d37b72246247151f4de7715dc4a15cdd0851733d 100644
--- a/tools/gn/test_with_scope.cc
+++ b/tools/gn/test_with_scope.cc
@@ -8,19 +8,6 @@
#include "tools/gn/parser.h"
#include "tools/gn/tokenizer.h"
-namespace {
-
-void SetCommandForTool(const std::string& cmd, Tool* tool) {
- Err err;
- SubstitutionPattern command;
- command.Parse(cmd, nullptr, &err);
- CHECK(!err.has_error())
- << "Couldn't parse \"" << cmd << "\", " << "got " << err.message();
- tool->set_command(command);
-}
-
-} // namespace
-
TestWithScope::TestWithScope()
: build_settings_(),
settings_(&build_settings_, std::string()),
@@ -132,6 +119,16 @@ void TestWithScope::SetupToolchain(Toolchain* toolchain) {
toolchain->ToolchainSetupComplete();
}
+// static
+void TestWithScope::SetCommandForTool(const std::string& cmd, Tool* tool) {
+ Err err;
+ SubstitutionPattern command;
+ command.Parse(cmd, nullptr, &err);
+ CHECK(!err.has_error())
+ << "Couldn't parse \"" << cmd << "\", " << "got " << err.message();
+ tool->set_command(command);
+}
+
void TestWithScope::AppendPrintOutput(const std::string& str) {
print_output_.append(str);
}
« no previous file with comments | « tools/gn/test_with_scope.h ('k') | tools/gn/tool.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698