Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: tools/gn/source_file_type.h

Issue 1207903002: Windows precompiled header support in GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Scott's grammar nits Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/path_output.cc ('k') | tools/gn/source_file_type.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/source_file_type.h
diff --git a/tools/gn/source_file_type.h b/tools/gn/source_file_type.h
index f738daacb4602957bb8ca72730fc7229b8d61505..c43b4324443e5184709390fd5bfb658fc6a5edfd 100644
--- a/tools/gn/source_file_type.h
+++ b/tools/gn/source_file_type.h
@@ -7,11 +7,13 @@
class SourceFile;
+// This should be sequential integers starting from 0 so they can be used as
+// array indices.
enum SourceFileType {
- SOURCE_UNKNOWN,
+ SOURCE_UNKNOWN = 0,
SOURCE_ASM,
SOURCE_C,
- SOURCE_CC,
+ SOURCE_CPP,
SOURCE_H,
SOURCE_M,
SOURCE_MM,
@@ -19,6 +21,9 @@ enum SourceFileType {
SOURCE_RC,
SOURCE_O, // Object files can be inputs, too. Also counts .obj.
SOURCE_DEF,
+
+ // Must be last.
+ SOURCE_NUMTYPES,
};
SourceFileType GetSourceFileType(const SourceFile& file);
« no previous file with comments | « tools/gn/path_output.cc ('k') | tools/gn/source_file_type.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698