Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1284)

Issue 1203533003: Clarify iOS flush-to-zero status. (Closed)

Created:
5 years, 6 months ago by bungeman-skia
Modified:
5 years, 6 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Clarify iOS flush-to-zero status. Modern processors support flush-to-zero and denormalized-are-zero for floating point operations (with ARM NEON unable to disable them). However, iOS on ARM is the only current system which defaults processes to using both all the time. However, this is only iOS on ARM, iOS on x86 (the simulator) does not. Correctly defining this allows the math tests to run error free in the simulator. Committed: https://skia.googlesource.com/skia/+/4760f32f2a68acdcfee53eae98bbdabb19238e8d

Patch Set 1 #

Patch Set 2 : Commit the real code change. #

Patch Set 3 : Use 'defined' for consistency. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M src/core/SkFloatBits.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkMathPriv.h View 1 2 1 chunk +7 lines, -3 lines 0 comments Download
M src/core/SkPoint.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
bungeman-skia
5 years, 6 months ago (2015-06-22 20:10:11 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1203533003/40001
5 years, 6 months ago (2015-06-22 21:42:29 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-22 21:48:28 UTC) #6
mtklein
lgtm
5 years, 6 months ago (2015-06-24 20:02:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1203533003/40001
5 years, 6 months ago (2015-06-24 20:03:14 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 20:08:56 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/4760f32f2a68acdcfee53eae98bbdabb19238e8d

Powered by Google App Engine
This is Rietveld 408576698