Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1201623003: fix for calling bindFragDataLocation on OpenGL 2.1 (Closed)

Created:
5 years, 6 months ago by joshua.litt
Modified:
5 years, 6 months ago
Reviewers:
joshualitt, egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fix for calling bindFragDataLocation on OpenGL 2.1 BUG=skia:3966 Committed: https://skia.googlesource.com/skia/+/c1f56b518218d1caa65d6b7101bebf0d28c02a92

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M src/gpu/gl/GrGLCaps.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 2 chunks +5 lines, -0 lines 0 comments Download
M src/gpu/gl/builders/GrGLFragmentShaderBuilder.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
joshualitt
ptal
5 years, 6 months ago (2015-06-22 17:45:35 UTC) #2
egdaniel
lgtm
5 years, 6 months ago (2015-06-22 19:25:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1201623003/1
5 years, 6 months ago (2015-06-22 19:25:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1201623003/1
5 years, 6 months ago (2015-06-22 19:26:47 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-22 19:31:35 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c1f56b518218d1caa65d6b7101bebf0d28c02a92

Powered by Google App Engine
This is Rietveld 408576698