Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 1199493002: Revert relanded strong property access CL (Closed)

Created:
5 years, 6 months ago by conradw
Modified:
5 years, 6 months ago
Reviewers:
rossberg
CC:
v8-dev, Yang, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert relanded strong property access CL Reason: Regressions in various benchmarks. Revert "Revert of Revert of [strong] Implement strong mode restrictions on property access (patchset #1 id:1 of https://codereview.chromium.org/1189153002/)" This reverts commit 41405c0470d5b30ec5d22665ed9430c46b33624f. Revert "X87: Revert of Revert of [strong] Implement strong mode restrictions on property access." This reverts commit 48de5f4d6b356d8da9db4afa68814df28e4b575d. Revert "Fix overlapping KeyedLoadIC bitfield." This reverts commit 4e6c956abfbfcd8ae193e6bb279cf96997b14e20. Revert "MIPS64: Fix 'Revert of Revert of [strong] Implement strong mode restrictions on property access'." This reverts commit 74f97b0d2a4a5102c2817c95139e94ebae900377. BUG= Committed: https://crrev.com/4ac7be56568f0ac71e7bf10e8bec33c33893e5b5 Cr-Commit-Position: refs/heads/master@{#29166}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+627 lines, -2175 lines) Patch
M src/arm/code-stubs-arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 8 chunks +7 lines, -13 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 3 chunks +7 lines, -8 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 7 chunks +8 lines, -13 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M src/builtins.h View 3 chunks +9 lines, -10 lines 0 comments Download
M src/builtins.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M src/code-factory.h View 1 chunk +3 lines, -6 lines 0 comments Download
M src/code-factory.cc View 1 chunk +8 lines, -17 lines 0 comments Download
M src/code-stubs.h View 5 chunks +7 lines, -29 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 6 chunks +11 lines, -10 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 4 chunks +7 lines, -9 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/js-operator.h View 4 chunks +4 lines, -16 lines 0 comments Download
M src/compiler/js-operator.cc View 5 chunks +10 lines, -14 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/full-codegen.h View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/hydrogen.h View 2 chunks +3 lines, -4 lines 0 comments Download
M src/hydrogen.cc View 7 chunks +15 lines, -19 lines 0 comments Download
M src/hydrogen-instructions.h View 6 chunks +5 lines, -17 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 6 chunks +7 lines, -13 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 3 chunks +7 lines, -8 lines 0 comments Download
M src/ic/arm/handler-compiler-arm.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M src/ic/arm/ic-arm.cc View 9 chunks +14 lines, -30 lines 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M src/ic/arm64/ic-arm64.cc View 10 chunks +16 lines, -35 lines 0 comments Download
M src/ic/handler-compiler.h View 2 chunks +1 line, -5 lines 0 comments Download
M src/ic/handler-compiler.cc View 3 chunks +4 lines, -9 lines 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M src/ic/ia32/ic-ia32.cc View 12 chunks +14 lines, -27 lines 0 comments Download
M src/ic/ic.h View 6 chunks +10 lines, -22 lines 0 comments Download
M src/ic/ic.cc View 15 chunks +31 lines, -71 lines 0 comments Download
M src/ic/ic-compiler.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/ic/ic-compiler.cc View 5 chunks +6 lines, -7 lines 0 comments Download
M src/ic/ic-inl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/ic/ic-state.h View 2 chunks +7 lines, -22 lines 0 comments Download
M src/ic/mips/handler-compiler-mips.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M src/ic/mips/ic-mips.cc View 9 chunks +14 lines, -28 lines 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M src/ic/mips64/ic-mips64.cc View 9 chunks +14 lines, -27 lines 0 comments Download
M src/ic/ppc/handler-compiler-ppc.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M src/ic/ppc/ic-ppc.cc View 9 chunks +14 lines, -28 lines 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M src/ic/x64/ic-x64.cc View 12 chunks +14 lines, -27 lines 0 comments Download
M src/ic/x87/handler-compiler-x87.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M src/ic/x87/ic-x87.cc View 12 chunks +14 lines, -27 lines 0 comments Download
M src/messages.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 8 chunks +7 lines, -13 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 3 chunks +7 lines, -8 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 8 chunks +7 lines, -13 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 3 chunks +7 lines, -8 lines 0 comments Download
M src/objects.h View 5 chunks +12 lines, -18 lines 0 comments Download
M src/objects.cc View 7 chunks +10 lines, -32 lines 0 comments Download
M src/objects-inl.h View 3 chunks +12 lines, -14 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ppc/full-codegen-ppc.cc View 8 chunks +7 lines, -13 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.cc View 3 chunks +7 lines, -8 lines 0 comments Download
M src/runtime/runtime.h View 3 chunks +6 lines, -12 lines 0 comments Download
M src/runtime/runtime-classes.cc View 3 chunks +20 lines, -50 lines 0 comments Download
M src/runtime/runtime-debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-object.cc View 6 chunks +104 lines, -117 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 8 chunks +7 lines, -13 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 3 chunks +7 lines, -8 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 6 chunks +7 lines, -13 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 3 chunks +7 lines, -8 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/strong/functions.js View 1 chunk +2 lines, -2 lines 0 comments Download
D test/mjsunit/strong/load-builtins.js View 1 chunk +0 lines, -42 lines 0 comments Download
D test/mjsunit/strong/load-element.js View 1 chunk +0 lines, -264 lines 0 comments Download
D test/mjsunit/strong/load-element-mutate-backing-store.js View 1 chunk +0 lines, -239 lines 0 comments Download
D test/mjsunit/strong/load-property.js View 1 chunk +0 lines, -200 lines 0 comments Download
D test/mjsunit/strong/load-property-mutate-backing-store.js View 1 chunk +0 lines, -174 lines 0 comments Download
M test/unittests/compiler/js-type-feedback-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 3 chunks +55 lines, -64 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
conradw
PTAL
5 years, 6 months ago (2015-06-19 16:44:03 UTC) #3
conradw
PTAL
5 years, 6 months ago (2015-06-19 16:44:03 UTC) #4
rossberg
LGTM (rubberstamp)
5 years, 6 months ago (2015-06-19 16:44:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1199493002/1
5 years, 6 months ago (2015-06-19 16:44:55 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-19 19:00:52 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-19 19:00:59 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4ac7be56568f0ac71e7bf10e8bec33c33893e5b5
Cr-Commit-Position: refs/heads/master@{#29166}

Powered by Google App Engine
This is Rietveld 408576698