Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Unified Diff: src/ic/ic-state.h

Issue 1199493002: Revert relanded strong property access CL (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ic/ic-inl.h ('k') | src/ic/mips/handler-compiler-mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ic/ic-state.h
diff --git a/src/ic/ic-state.h b/src/ic/ic-state.h
index e1fed191332cbe0ccccdda02e9f5b4df1ce51794..dbc504bf6d79f9f95d6a86e14eca0514198507f5 100644
--- a/src/ic/ic-state.h
+++ b/src/ic/ic-state.h
@@ -201,24 +201,11 @@ class CompareICState {
class LoadICState final BASE_EMBEDDED {
- private:
- class ContextualModeBits : public BitField<ContextualMode, 0, 1> {};
- class LanguageModeBits
- : public BitField<LanguageMode, ContextualModeBits::kNext, 2> {};
- STATIC_ASSERT(static_cast<int>(NOT_CONTEXTUAL) == 0);
- const ExtraICState state_;
-
public:
- static const uint32_t kNextBitFieldOffset = LanguageModeBits::kNext;
-
- static const ExtraICState kStrongModeState = STRONG
- << LanguageModeBits::kShift;
-
explicit LoadICState(ExtraICState extra_ic_state) : state_(extra_ic_state) {}
- explicit LoadICState(ContextualMode mode, LanguageMode language_mode)
- : state_(ContextualModeBits::encode(mode) |
- LanguageModeBits::encode(language_mode)) {}
+ explicit LoadICState(ContextualMode mode)
+ : state_(ContextualModeBits::encode(mode)) {}
ExtraICState GetExtraICState() const { return state_; }
@@ -226,17 +213,15 @@ class LoadICState final BASE_EMBEDDED {
return ContextualModeBits::decode(state_);
}
- LanguageMode language_mode() const {
- return LanguageModeBits::decode(state_);
- }
-
static ContextualMode GetContextualMode(ExtraICState state) {
return LoadICState(state).contextual_mode();
}
- static LanguageMode GetLanguageMode(ExtraICState state) {
- return LoadICState(state).language_mode();
- }
+ private:
+ class ContextualModeBits : public BitField<ContextualMode, 0, 1> {};
+ STATIC_ASSERT(static_cast<int>(NOT_CONTEXTUAL) == 0);
+
+ const ExtraICState state_;
};
« no previous file with comments | « src/ic/ic-inl.h ('k') | src/ic/mips/handler-compiler-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698