Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Side by Side Diff: src/runtime/runtime-debug.cc

Issue 1199493002: Revert relanded strong property access CL (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/runtime/runtime-classes.cc ('k') | src/runtime/runtime-object.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/arguments.h" 8 #include "src/arguments.h"
9 #include "src/compiler.h" 9 #include "src/compiler.h"
10 #include "src/debug.h" 10 #include "src/debug.h"
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 case LookupIterator::INTEGER_INDEXED_EXOTIC: 74 case LookupIterator::INTEGER_INDEXED_EXOTIC:
75 case LookupIterator::INTERCEPTOR: 75 case LookupIterator::INTERCEPTOR:
76 case LookupIterator::JSPROXY: 76 case LookupIterator::JSPROXY:
77 return it->isolate()->factory()->undefined_value(); 77 return it->isolate()->factory()->undefined_value();
78 case LookupIterator::ACCESSOR: { 78 case LookupIterator::ACCESSOR: {
79 Handle<Object> accessors = it->GetAccessors(); 79 Handle<Object> accessors = it->GetAccessors();
80 if (!accessors->IsAccessorInfo()) { 80 if (!accessors->IsAccessorInfo()) {
81 return it->isolate()->factory()->undefined_value(); 81 return it->isolate()->factory()->undefined_value();
82 } 82 }
83 MaybeHandle<Object> maybe_result = 83 MaybeHandle<Object> maybe_result =
84 JSObject::GetPropertyWithAccessor(it, SLOPPY); 84 JSObject::GetPropertyWithAccessor(it);
85 Handle<Object> result; 85 Handle<Object> result;
86 if (!maybe_result.ToHandle(&result)) { 86 if (!maybe_result.ToHandle(&result)) {
87 result = handle(it->isolate()->pending_exception(), it->isolate()); 87 result = handle(it->isolate()->pending_exception(), it->isolate());
88 it->isolate()->clear_pending_exception(); 88 it->isolate()->clear_pending_exception();
89 if (has_caught != NULL) *has_caught = true; 89 if (has_caught != NULL) *has_caught = true;
90 } 90 }
91 return result; 91 return result;
92 } 92 }
93 93
94 case LookupIterator::DATA: 94 case LookupIterator::DATA:
(...skipping 3093 matching lines...) Expand 10 before | Expand all | Expand 10 after
3188 return Smi::FromInt(isolate->debug()->is_active()); 3188 return Smi::FromInt(isolate->debug()->is_active());
3189 } 3189 }
3190 3190
3191 3191
3192 RUNTIME_FUNCTION(Runtime_DebugBreakInOptimizedCode) { 3192 RUNTIME_FUNCTION(Runtime_DebugBreakInOptimizedCode) {
3193 UNIMPLEMENTED(); 3193 UNIMPLEMENTED();
3194 return NULL; 3194 return NULL;
3195 } 3195 }
3196 } // namespace internal 3196 } // namespace internal
3197 } // namespace v8 3197 } // namespace v8
OLDNEW
« no previous file with comments | « src/runtime/runtime-classes.cc ('k') | src/runtime/runtime-object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698