Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 1199043006: Subzero. Adds x86-64 to the list of supported Subzero targets. (Closed)

Created:
5 years, 6 months ago by John
Modified:
5 years, 6 months ago
Reviewers:
Jim Stichnoth
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : git pull #

Patch Set 3 : Fixes unused variable warnings. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -40 lines) Patch
M Makefile.standalone View 1 2 chunks +2 lines, -0 lines 0 comments Download
M src/IceAssemblerX8664.h View 1 4 chunks +13 lines, -28 lines 0 comments Download
A src/IceAssemblerX8664.cpp View 1 2 1 chunk +47 lines, -0 lines 0 comments Download
M src/IceTargetLoweringX8664.h View 1 5 chunks +32 lines, -12 lines 0 comments Download
A src/IceTargetLoweringX8664.cpp View 1 2 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
John
5 years, 6 months ago (2015-06-23 22:24:13 UTC) #2
Jim Stichnoth
lgtm
5 years, 6 months ago (2015-06-23 22:51:04 UTC) #3
John
5 years, 6 months ago (2015-06-23 22:55:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
d58f01cacd4d04f5bcc7f3d6b5ee85abe4970eaa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698