Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: src/IceAssemblerX8664.h

Issue 1199043006: Subzero. Adds x86-64 to the list of supported Subzero targets. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Fixes unused variable warnings. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Makefile.standalone ('k') | src/IceAssemblerX8664.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceAssemblerX8664.h
diff --git a/src/IceAssemblerX8664.h b/src/IceAssemblerX8664.h
index 3ed52a88c6d5bd307b72e469f3a646a7954ac95a..de19b6501daae23b62e74230f85c9f70f85cc6c2 100644
--- a/src/IceAssemblerX8664.h
+++ b/src/IceAssemblerX8664.h
@@ -1,4 +1,4 @@
-//===- subzero/src/IceAssemberX8664.h - Assembler for x86-64 ----*- C++ -*-===//
+//===- subzero/src/IceAssemblerX8664.h - Assembler for x86-64 -*- C++ -*---===//
//
// The Subzero Code Generator
//
@@ -7,7 +7,7 @@
//
//===----------------------------------------------------------------------===//
//
-// This file implements the Assembler class for x86-64.h.
+// This file implements the Assembler class for x86-64.
//
//===----------------------------------------------------------------------===//
@@ -15,6 +15,7 @@
#define SUBZERO_SRC_ICEASSEMBLERX8664_H
#include "IceAssembler.h"
+#include "IceDefs.h"
namespace Ice {
namespace X8664 {
@@ -25,36 +26,20 @@ class AssemblerX8664 final : public Assembler {
public:
explicit AssemblerX8664(bool use_far_branches = false) : Assembler() {
+ assert(!use_far_branches);
+ (void)use_far_branches;
llvm::report_fatal_error("Not yet implemented");
}
- void alignFunction() override {
- llvm::report_fatal_error("Not yet implemented");
- }
-
- void padWithNop(intptr_t Padding) override {
- llvm::report_fatal_error("Not yet implemented");
- }
+ ~AssemblerX8664() override = default;
- SizeT getBundleAlignLog2Bytes() const override {
- llvm::report_fatal_error("Not yet implemented");
- }
-
- const char *getNonExecPadDirective() const override {
- llvm::report_fatal_error("Not yet implemented");
- }
-
- llvm::ArrayRef<uint8_t> getNonExecBundlePadding() const override {
- llvm::report_fatal_error("Not yet implemented");
- }
-
- void bindCfgNodeLabel(SizeT NodeNumber) override {
- llvm::report_fatal_error("Not yet implemented");
- }
-
- bool fixupIsPCRel(FixupKind Kind) const override {
- llvm::report_fatal_error("Not yet implemented");
- }
+ void alignFunction() override;
+ void padWithNop(intptr_t Padding) override;
+ SizeT getBundleAlignLog2Bytes() const override;
+ const char *getNonExecPadDirective() const override;
+ llvm::ArrayRef<uint8_t> getNonExecBundlePadding() const override;
+ void bindCfgNodeLabel(SizeT NodeNumber) override;
+ bool fixupIsPCRel(FixupKind Kind) const override;
};
} // end of namespace X8664
« no previous file with comments | « Makefile.standalone ('k') | src/IceAssemblerX8664.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698