Issue 1201483005: Subzero. Adds x86-64 to the list of supported Subzero targets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1201483005: Subzero. Adds x86-64 to the list of supported Subzero targets. (Closed)

Created:
5 years, 6 months ago by John

Modified:
5 years, 6 months ago

Reviewers:
Jim Stichnoth

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master

Target Ref:
refs/heads/master

Project:
nacl

Visibility:
Public.

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	pnacl/build.sh	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	toolchain_build/toolchain_build_pnacl.py	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

Jim Stichnoth

LGTM, though before landing this, the other 2 CLs need to be landed and COMPONENT_REVISIONS ...

5 years, 6 months ago (2015-06-23 22:38:38 UTC) #3

John

5 years, 6 months ago (2015-06-25 17:04:16 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
18abd2755ed60c5efb20d4a8641a397b644ea56d (presubmit successful).