Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Unified Diff: components/history/core/browser/expire_history_backend_unittest.cc

Issue 1198373002: Split HistoryClient in two objects (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@1192403002
Patch Set: Add comments in ChromeHistoryBackendClient Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/history/core/browser/expire_history_backend_unittest.cc
diff --git a/components/history/core/browser/expire_history_backend_unittest.cc b/components/history/core/browser/expire_history_backend_unittest.cc
index c3783201409bc3ac2a010bb39f24dcaab4d1c0e1..f1219a4d76ebbe8f187a2eb1674d3502fcf89ee2 100644
--- a/components/history/core/browser/expire_history_backend_unittest.cc
+++ b/components/history/core/browser/expire_history_backend_unittest.cc
@@ -21,6 +21,7 @@
#include "base/scoped_observer.h"
#include "base/strings/string16.h"
#include "base/strings/utf_string_conversions.h"
+#include "components/history/core/browser/history_backend_client.h"
#include "components/history/core/browser/history_backend_notifier.h"
#include "components/history/core/browser/history_constants.h"
#include "components/history/core/browser/history_database.h"
@@ -51,7 +52,8 @@ bool MockCanAddURLToHistory(const GURL& url) {
class ExpireHistoryTest : public testing::Test, public HistoryBackendNotifier {
public:
ExpireHistoryTest()
- : expirer_(this, &history_client_, message_loop_.task_runner()),
+ : backend_client_(history_client_.CreateBackendClient()),
+ expirer_(this, backend_client_.get(), message_loop_.task_runner()),
now_(base::Time::Now()) {}
protected:
@@ -93,6 +95,7 @@ class ExpireHistoryTest : public testing::Test, public HistoryBackendNotifier {
base::ScopedTempDir tmp_dir_;
HistoryClientFakeBookmarks history_client_;
+ scoped_ptr<HistoryBackendClient> backend_client_;
base::MessageLoopForUI message_loop_;
« no previous file with comments | « components/history/core/browser/expire_history_backend.cc ('k') | components/history/core/browser/history_backend.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698