components/history/core/browser/history_service.cc - Issue 1198373002: Split HistoryClient in two objects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/history/core/browser/history_service.cc

Issue 1198373002: Split HistoryClient in two objects (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@1192403002

Patch Set: Add comments in ChromeHistoryBackendClient Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/history/core/browser/history_service.cc

diff --git a/components/history/core/browser/history_service.cc b/components/history/core/browser/history_service.cc

index 0f136703fcdf559113e4d3f0cd15a4729f2d8115..da0ed64137e740b8f4b79894060d797b5ffa0d98 100644

--- a/components/history/core/browser/history_service.cc

+++ b/components/history/core/browser/history_service.cc

@@ -32,6 +32,7 @@

#include "base/trace_event/trace_event.h"

#include "components/history/core/browser/download_row.h"

#include "components/history/core/browser/history_backend.h"

+#include "components/history/core/browser/history_backend_client.h"

#include "components/history/core/browser/history_client.h"

#include "components/history/core/browser/history_database_params.h"

#include "components/history/core/browser/history_db_task.h"

@@ -877,7 +878,8 @@ bool HistoryService::Init(

scoped_refptr<HistoryBackend> backend(new HistoryBackend(

new BackendDelegate(weak_ptr_factory_.GetWeakPtr(),

base::ThreadTaskRunnerHandle::Get()),

- history_client_.get(), thread_->task_runner()));

+ history_client_ ? history_client_->CreateBackendClient() : nullptr,

+ thread_->task_runner()));

history_backend_.swap(backend);

ScheduleTask(PRIORITY_UI,