chrome/browser/ui/startup/session_crashed_infobar_delegate_unittest.cc - Issue 1198313003: Fix the browser match rules.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/startup/session_crashed_infobar_delegate_unittest.cc

Issue 1198313003: Fix the browser match rules. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use scoped_ptr<Browser> instead. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller_unittest.mm ('K') | « chrome/browser/ui/cocoa/profiles/profile_menu_controller_unittest.mm ('k') | chrome/browser/ui/tab_contents/tab_contents_iterator_unittest.cc » ('j') | chrome/test/base/test_browser_window.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/startup/session_crashed_infobar_delegate_unittest.cc

diff --git a/chrome/browser/ui/startup/session_crashed_infobar_delegate_unittest.cc b/chrome/browser/ui/startup/session_crashed_infobar_delegate_unittest.cc

index 1bb6a04727eb1c98a26dc8b4867b5b773876e512..017213c5acae811fc1fd98a52296884c965dc105 100644

--- a/chrome/browser/ui/startup/session_crashed_infobar_delegate_unittest.cc

+++ b/chrome/browser/ui/startup/session_crashed_infobar_delegate_unittest.cc

@@ -58,8 +58,8 @@ TEST_F(SessionCrashedInfoBarDelegateUnitTest, DetachingTabWithCrashedInfoBar) {

// Create a browser which we can close during the test.

Browser::CreateParams params(browser()->profile(),

browser()->host_desktop_type());

- scoped_ptr<Browser> first_browser(

- chrome::CreateBrowserWithTestWindowForParams(&params));

+ scoped_ptr<Browser> first_browser =

+ chrome::CreateBrowserWithTestWindowForParams(&params);

AddTab(first_browser.get(), GURL(chrome::kChromeUINewTabURL));

// Attach the crashed infobar to it.

@@ -76,8 +76,8 @@ TEST_F(SessionCrashedInfoBarDelegateUnitTest, DetachingTabWithCrashedInfoBar) {

ASSERT_TRUE(infobar);

// Open another browser.

- scoped_ptr<Browser> opened_browser(

- chrome::CreateBrowserWithTestWindowForParams(&params));

+ scoped_ptr<Browser> opened_browser =

+ chrome::CreateBrowserWithTestWindowForParams(&params);

// Move the tab which is destroying the crash info bar to the new browser.

tab_strip->DetachWebContentsAt(0);