chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller_unittest.mm - Issue 1198313003: Fix the browser match rules.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller_unittest.mm

Issue 1198313003: Fix the browser match rules. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use scoped_ptr<Browser> instead. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/browser_finder_chromeos_unittest.cc ('K') | « chrome/browser/ui/browser_iterator_unittest.cc ('k') | chrome/browser/ui/cocoa/profiles/profile_menu_controller_unittest.mm » ('j') | chrome/test/base/test_browser_window.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller_unittest.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller_unittest.mm

index 7a1d74333503aed5e4b4d6d7f10124213a32aa60..e2a1bc927780114fd2e19457aa1bf1781b8363e1 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller_unittest.mm

@@ -101,7 +101,8 @@ class BookmarkEditorBaseControllerTest : public CocoaProfileTest {

Browser* CreateBrowser() override {

Browser::CreateParams native_params(profile(), chrome::GetActiveDesktop());

msw 2015/07/09 22:37:37 nit: s/native_params/params/ for a one-liner below

xdai1 2015/07/09 23:45:40 Done.

- return chrome::CreateBrowserWithTestWindowForParams(&native_params);

+ return chrome::CreateBrowserWithTestWindowForParams(&native_params)

+ .release();

}

};