Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/tab_contents/tab_contents_iterator_unittest.cc

Issue 1198313003: Fix the browser match rules. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use scoped_ptr<Browser> instead. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller_unittest.mm ('K') | « chrome/browser/ui/startup/session_crashed_infobar_delegate_unittest.cc ('k') | chrome/browser/ui/tabs/pinned_tab_service_unittest.cc » ('j') | chrome/test/base/test_browser_window.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/tab_contents/tab_contents_iterator_unittest.cc
diff --git a/chrome/browser/ui/tab_contents/tab_contents_iterator_unittest.cc b/chrome/browser/ui/tab_contents/tab_contents_iterator_unittest.cc
index 9d36fddb91af4d70793a2408a4a145db740b3127..3419819ef1f0c2b5919c7f8df4668c8af33e2bee 100644
--- a/chrome/browser/ui/tab_contents/tab_contents_iterator_unittest.cc
+++ b/chrome/browser/ui/tab_contents/tab_contents_iterator_unittest.cc
@@ -44,15 +44,15 @@ TEST_F(BrowserListTest, TabContentsIteratorVerifyCount) {
// Create more browsers/windows.
Browser::CreateParams native_params(profile(),
chrome::HOST_DESKTOP_TYPE_NATIVE);
- scoped_ptr<Browser> browser2(
- chrome::CreateBrowserWithTestWindowForParams(&native_params));
+ scoped_ptr<Browser> browser2 =
+ chrome::CreateBrowserWithTestWindowForParams(&native_params);
// Create browser 3 and 4 on the Ash desktop (the TabContentsIterator
// shouldn't see the difference).
Browser::CreateParams ash_params(profile(), chrome::HOST_DESKTOP_TYPE_ASH);
- scoped_ptr<Browser> browser3(
- chrome::CreateBrowserWithTestWindowForParams(&ash_params));
- scoped_ptr<Browser> browser4(
- chrome::CreateBrowserWithTestWindowForParams(&ash_params));
+ scoped_ptr<Browser> browser3 =
+ chrome::CreateBrowserWithTestWindowForParams(&ash_params);
+ scoped_ptr<Browser> browser4 =
+ chrome::CreateBrowserWithTestWindowForParams(&ash_params);
// Sanity checks.
#if defined(OS_CHROMEOS)
« chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller_unittest.mm ('K') | « chrome/browser/ui/startup/session_crashed_infobar_delegate_unittest.cc ('k') | chrome/browser/ui/tabs/pinned_tab_service_unittest.cc » ('j') | chrome/test/base/test_browser_window.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698