chrome/browser/ui/cocoa/profiles/profile_menu_controller_unittest.mm - Issue 1198313003: Fix the browser match rules.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/profiles/profile_menu_controller_unittest.mm

Issue 1198313003: Fix the browser match rules. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use scoped_ptr<Browser> instead. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller_unittest.mm ('K') | « chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller_unittest.mm ('k') | chrome/browser/ui/startup/session_crashed_infobar_delegate_unittest.cc » ('j') | chrome/test/base/test_browser_window.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/profiles/profile_menu_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/profiles/profile_menu_controller_unittest.mm b/chrome/browser/ui/cocoa/profiles/profile_menu_controller_unittest.mm

index 6d701689cefad2a317e0ab09056f0a41f5d69465..83fef3d66bb68137f011b73acd8bfa8e066655e8 100644

--- a/chrome/browser/ui/cocoa/profiles/profile_menu_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/profiles/profile_menu_controller_unittest.mm

@@ -201,8 +201,8 @@ TEST_F(ProfileMenuControllerTest, SetActiveAndRemove) {

// Create a browser and "show" it.

Browser::CreateParams profile2_params(profile2, chrome::GetActiveDesktop());

- scoped_ptr<Browser> p2_browser(

- chrome::CreateBrowserWithTestWindowForParams(&profile2_params));

+ scoped_ptr<Browser> p2_browser =

+ chrome::CreateBrowserWithTestWindowForParams(&profile2_params);

BrowserList::SetLastActive(p2_browser.get());

VerifyProfileNamedIsActive(@"Profile 2", __LINE__);

@@ -212,8 +212,8 @@ TEST_F(ProfileMenuControllerTest, SetActiveAndRemove) {

// Open a new browser and make sure it takes effect.

Browser::CreateParams profile3_params(profile3, chrome::GetActiveDesktop());

- scoped_ptr<Browser> p3_browser(

- chrome::CreateBrowserWithTestWindowForParams(&profile3_params));

+ scoped_ptr<Browser> p3_browser =

+ chrome::CreateBrowserWithTestWindowForParams(&profile3_params);

BrowserList::SetLastActive(p3_browser.get());

VerifyProfileNamedIsActive(@"Profile 3", __LINE__);

@@ -282,8 +282,8 @@ TEST_F(ProfileMenuControllerTest, SupervisedProfile) {

// Open a new browser for the supervised user and switch to it.

Browser::CreateParams supervised_profile_params(

supervised_profile, chrome::HOST_DESKTOP_TYPE_NATIVE);

- scoped_ptr<Browser> supervised_browser(

- chrome::CreateBrowserWithTestWindowForParams(&supervised_profile_params));

+ scoped_ptr<Browser> supervised_browser =

+ chrome::CreateBrowserWithTestWindowForParams(&supervised_profile_params);

BrowserList::SetLastActive(supervised_browser.get());

item = [menu itemAtIndex:0];