Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 1197493002: Adds a SpriteWidget and simplifies sample game setup (Closed)

Created:
5 years, 6 months ago by viktorl
Modified:
5 years, 6 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -115 lines) Patch
M sky/examples/game/lib/game_demo.dart View 1 chunk +0 lines, -2 lines 0 comments Download
D sky/examples/game/lib/game_demo_box.dart View 1 chunk +0 lines, -79 lines 0 comments Download
M sky/examples/game/lib/game_demo_world.dart View 2 chunks +4 lines, -1 line 0 comments Download
M sky/examples/game/lib/sprite_box.dart View 6 chunks +28 lines, -23 lines 0 comments Download
A sky/examples/game/lib/sprite_widget.dart View 1 chunk +15 lines, -0 lines 3 comments Download
M sky/examples/game/lib/sprites.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/examples/game/main.dart View 2 chunks +1 line, -10 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
viktorl
5 years, 6 months ago (2015-06-19 00:13:11 UTC) #2
abarth-chromium
https://codereview.chromium.org/1197493002/diff/1/sky/examples/game/lib/sprite_widget.dart File sky/examples/game/lib/sprite_widget.dart (right): https://codereview.chromium.org/1197493002/diff/1/sky/examples/game/lib/sprite_widget.dart#newcode8 sky/examples/game/lib/sprite_widget.dart:8: SpriteWidget(NodeWithSize this._rootNode, [SpriteBoxTransformMode this._transformMode = SpriteBoxTransformMode.letterbox]); You can remove ...
5 years, 6 months ago (2015-06-19 00:18:07 UTC) #3
abarth-chromium
lgtm
5 years, 6 months ago (2015-06-19 16:09:00 UTC) #4
viktorl
5 years, 6 months ago (2015-06-19 16:14:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
96b8393884d9c1303b9dbfbe8a075655be66bc32 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698